Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): add v10 and v11 to CI #921

Merged
merged 1 commit into from Dec 3, 2018
Merged

chore(node): add v10 and v11 to CI #921

merged 1 commit into from Dec 3, 2018

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Dec 3, 2018

This adds support for v10 and v11, and removes a TODO.

This adds support for v10 and v11, and removes a TODO.
@nfischer nfischer added the chore label Dec 3, 2018
@nfischer nfischer merged commit 355287e into master Dec 3, 2018
4 checks passed
@nfischer nfischer deleted the chore-node-10-11 branch Dec 3, 2018
@@ -5,6 +5,8 @@ node_js:
- 7
- 8
- 9
- 10
- 11
Copy link
Contributor

@DanielRuf DanielRuf Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still recommend node (fail early and also auto update when 12 comes out - otherwise we might miss the release of 12 and there could be breaking changes so someone has to update the CI config again when a new major version is released).

Copy link
Member Author

@nfischer nfischer Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. You raise a good point, but node isn't really the answer: in that case we would test 12 but miss 11, which is not what we want. Even if we didn't test unsupported node releases, we'd still hit this problem between 12 & 13 (at which point both would be supported).

IMO auto updating is not desirable, because a breaking change in 12 would cause CI to fail suddenly on master and CI would reject unrelated PRs.

Let me know if you see a better path forward.

Copy link
Contributor

@DanielRuf DanielRuf Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to test 11 when 12 is released as it will reach its EOL then and 13 will be released. See https://github.com/nodejs/Release/blob/master/schedule.png

But I guess we can currently keep it as is. Both ways / solutions have their advantages and disadvantages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants