Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): initial support for long options #926

Merged
merged 2 commits into from Jan 5, 2019
Merged

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Jan 4, 2019

This adds initial support for long options. This integration tests them
with shell.touch() and unit tests them in test/common.js. This
documents the new syntax.

This also refactors some of the common internals:

  • Creates a new CommandError type to replace the 'earlyExit' hack
  • Clearer Error types for parseOptions() exceptions
  • Removes side effects from a test which modifies common.config
  • Fixes appveyor and travis config to run lint (regressed in #920)

Issue #924
Test: touch.js, common.js

nfischer added 2 commits Jan 4, 2019
This adds initial support for long options. This integration tests them
with `shell.touch()` and unit tests them in `test/common.js`. This
documents the new syntax.

This also refactors some of the common internals:

 * Creates a new CommandError type to replace the `'earlyExit'` hack
 * Clearer Error types for `parseOptions()` exceptions
 * Removes side effects from a test which modifies `common.config`
 * Fixes appveyor and travis config to run lint (regressed in #920)

Issue #924
Test: touch.js, common.js
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 4, 2019

Codecov Report

Merging #926 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   97.26%   97.28%   +0.01%     
==========================================
  Files          34       34              
  Lines        1281     1290       +9     
==========================================
+ Hits         1246     1255       +9     
  Misses         35       35
Impacted Files Coverage Δ
src/touch.js 100% <ø> (ø) ⬆️
src/common.js 98.46% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5371e16...7a5afec. Read the comment docs.

@nfischer nfischer merged commit 1560ffd into master Jan 5, 2019
4 checks passed
@nfischer nfischer deleted the feat-long-options branch Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants