-
Notifications
You must be signed in to change notification settings - Fork 53
feat(preview): add send email button #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preview): add send email button #109
Conversation
|
Hello @affanshahid, Appreciate your pull request. Nevertheless, we're currently exploring an alternative method to incorporate this feature, steering away from a direct port from react-email. I'll be closing this now. Feel free to connect on Discord for any questions or inquiries. |
|
A bit premature to close this one. |
|
@affanshahid we've got some things cooking behind the scenes, and would like to integrate your work into it. please hold tight, we're going to leave the PR open but it'll probably go a tad slower than normal for this project. |
|
Good news; we got some info back from a provider we're going to partner with. Will drop some information on the PR here tomorrow. |
|
hey @affanshahid we didn't forget about this. @lordelogos is working on a gist with info for the provider we're going to roll with. the one bit of feedback I did immediately have was that I'd like to keep the "view selection" button group floated to the right. if you're cool with it, I'd like to move the does that sound good? |
|
Sounds good, I'll make the changes |
|
Hey @affanshahid Here's a doc containing the implementation details Let me know if you have any questions or need any help |
|
@lordelogos Just a note, I had to exclude the Also, the provided logo has a white background which looks like this: Not sure if it would be right to alter SVG to remove the bg but if I do, it looks like this: If I change the color to match the theme (again, not sure if a good idea), it looks like this: Let me know which approach you would prefer. |
|
Hey @affanshahid, (btw, personally I prefer the last option that matches the theme) |
|
I've changed the button, this is what it looks like now: Screen.Recording.2024-01-14.at.7.14.57.PM.movI had to add a bg, unlike the buttons in the code view otherwise it becomes hard to see on light backgrounds. I think we can do without the bounce animation, or at least disable it in the mobile view. |
|
That looks fantastic! I really do love the bounce animation, but agree that we don't need it on the mobile view. Two bounces is probably enough, and probably only when the first email template is opened (not sure how hard that would be to implement). @affanshahid what are your thoughts on that approach? |
|
Also a fan of the "pulse" CTA as well. Totally up to you https://codepen.io/saigowthamr/pen/PowdZqy / https://www.florin-pop.com/blog/2019/03/css-pulse-effect/ (I used one on a project years ago and always liked it https://github.com/shellscape/webpack-plugin-serve?tab=readme-ov-file#status) |
|
Yes makes sense to only run the animation once or twice. Here's a comparison of bounce vs pulse: Screen.Recording.2024-01-14.at.9.29.35.PM.movScreen.Recording.2024-01-14.at.9.39.12.PM.movBoth look fine to me |
|
I'm partial to the pulse, but I'd like to give you the final say 😄 |
|
Pulse it is 👍🏻 |
|
awesome. I'll clone your branch here and give things a run through in a bit. this is a huge win for the project! |
|
Hey guys, I know i'm late to the party but I'm for bounce especially the 2 bounces at the start |
|
@affanshahid you've got two different opinions from maintainers haha 😆 as the PR author I think it's fair for you to be the deciding vote! |
|
I think the pulse might be more attention grabbing, so let's go with that for now. |
|
@affanshahid had the chance to check out your branch tonight. everything worked great! I've got one more request, if you're up for it: when the |
|
just checked out those changes and they look awesome. thanks for adding that! |
|
This is what it looks like now: Screen.Recording.2024-01-16.at.7.37.47.PM.mov |



Component / Package Name: jsx-email
This PR contains:
Are tests included?
Breaking Changes?
Description
This PR ports the "send preview email" feature from react-email using Resend. This is really useful for testing emails in your email client by directly sending them from the preview UI.
I think this is a really important feature to have but let me know what you think.
I did not add tests because I could not find other tests for the preview app.