fix(jsx-email): remove qr-code #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordelogos
changed the title
|
you probably need to run |
lordelogos
force-pushed
the
feat/remove-qrcode
branch
2 times, most recently
from
1fe4d48 to
7587fa0
Compare
shellscape
force-pushed
the
feat/remove-qrcode
branch
from
7587fa0 to
1890d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component / Package Name:
jsx-email
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This PR removes the
QrCodecomponent.The component was never tested within the preview, and only worked within a server-side render or direct call to
render. That combined with the fact that the data-uri format isn't widely supported means that this just isn't ready to be included. This is not a breaking change because the component was never correctly exported from jsx-email (oops).