Skip to content

fix(app-preview): ignore empty modules #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

shellscape
Copy link
Owner

Component / Package Name: app-preview

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Fixes #125

Description

Adds some code to handle and edge case with empty files in the target preview directory.

@shellscape shellscape merged commit 5f15d44 into main Jan 8, 2024
@shellscape shellscape deleted the fix/app-preview/ignore-empty-modules branch January 8, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previewer hang when using empty files and default arguments
1 participant