New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on inline comments. Closes #114 #115

Merged
merged 2 commits into from Sep 22, 2018

Conversation

Projects
None yet
2 participants
@jwilsson
Collaborator

jwilsson commented Sep 22, 2018

Which issue # if any, does this resolve?
#114

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

jwilsson and others added some commits Sep 22, 2018

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Sep 22, 2018

Owner

@jwilsson I forgot to enable Circle builds on forks (I'm such a goofball), they'll run the next time around. Also sent you a collaborator invite so you can handle bugs and such in the event I'm not on top of it immediately.

Owner

shellscape commented Sep 22, 2018

@jwilsson I forgot to enable Circle builds on forks (I'm such a goofball), they'll run the next time around. Also sent you a collaborator invite so you can handle bugs and such in the event I'm not on top of it immediately.

@shellscape shellscape merged commit b60edba into shellscape:master Sep 22, 2018

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Sep 22, 2018

Owner

3.0.1 is up

Owner

shellscape commented Sep 22, 2018

3.0.1 is up

@jwilsson jwilsson deleted the jwilsson:issue-114 branch Sep 22, 2018

@jwilsson

This comment has been minimized.

Show comment
Hide comment
@jwilsson

jwilsson Sep 22, 2018

Collaborator

Awesome, thanks for the quick response!

Collaborator

jwilsson commented Sep 22, 2018

Awesome, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment