New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixin parameters with functions. fixes #122 #125

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@shellscape
Owner

shellscape commented Nov 13, 2018

Which issue # if any, does this resolve?

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

Fixes #122. When mixing parameters contain declarations with functions (or any other declaration that contains parenthesis pairs), the parser was throwing a syntax error.

@shellscape shellscape requested a review from jwilsson Nov 13, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 13, 2018

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           8        8           
  Lines         188      188           
=======================================
  Hits          180      180           
  Misses          8        8
Impacted Files Coverage Δ
lib/LessParser.js 98.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3016597...5a2bc2b. Read the comment docs.

@jwilsson

Much simpler than the approach I had in mind! LGTM.

@shellscape shellscape merged commit 9392246 into master Nov 13, 2018

8 checks passed

ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: dependency_cache Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v6-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v8-latest Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.74%)
Details
codecov/project 95.74% (+0%) compared to 3016597
Details
security/snyk - package.json (shellscape) No manifest changes detected

@shellscape shellscape deleted the fix/keyframes branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment