Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why require delnodes.dmp and merged.dmp? #27

Closed
nick-youngblut opened this issue Nov 7, 2019 · 5 comments
Closed

Why require delnodes.dmp and merged.dmp? #27

nick-youngblut opened this issue Nov 7, 2019 · 5 comments

Comments

@nick-youngblut
Copy link

I created a tool for converting the Genomes Taxonomy DataBase (GTDB) taxonomy to nodes.dmp & names.dmp files. The tool is gtdb_to_taxdump. The output works with taxonkit<0.5.0, but fails for taxonkit>=0.5.0, since you now require delnodes.dmp and merged.dmp. Why do you require these files? Could an option be included to override that requirement or is it absolutely necessary for taxonkit 0.5 to work?

@shenwei356
Copy link
Owner

Because we'd like to detect merged or deleted taxids, see #19 .

I can make it optional. You can also try again by creating empty delnodes.dmp merged.dmp .

@nick-youngblut
Copy link
Author

Thanks for the quick reply! I tried just creating empty delnodes.dmp and merged.dmp files, but I then get a "file empty" error.

@shenwei356
Copy link
Owner

try adding a line staring with #

@nick-youngblut
Copy link
Author

That works as long as the file contains #\n. Thanks!

@shenwei356
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants