Skip to content

Update Dockerfile - #2216

Merged
ppfeister merged 3 commits into
masterfrom
2195-update-dockerfile
Jul 8, 2024
Merged

ppfeister merged 3 commits into
masterfrom
2195-update-dockerfile

Conversation

@ppfeister

Copy link
Copy Markdown
Member

Closes #2195

Removes Dockerfile's dependency on requirements.txt
Now uses Sherlock's PyPI image rather than building from source (more consistent across platforms, prevents hanging commits)

@ppfeister ppfeister added the staged - do not merge PR is staged for coordinated release label Jul 1, 2024
@ppfeister ppfeister changed the title 2195 update dockerfile Update Dockerfile Jul 1, 2024
@ppfeister

ppfeister commented Jul 1, 2024 •

Copy link
Copy Markdown
Member Author

Needs SHERLOCK_ENV var set.

This requirement is not a blocker, however.


Edit: Added SHERLOCK_ENV

@ppfeister
ppfeister merged commit 9aa8242 into master Jul 8, 2024
@ppfeister
ppfeister deleted the 2195-update-dockerfile branch July 8, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

staged - do not merge PR is staged for coordinated release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile reliant upon requirements.txt and local build

2 participants