Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: Improve Docs to Update the Rules #9

Merged
merged 4 commits into from Oct 21, 2023

Conversation

adiati98
Copy link
Collaborator

@adiati98 adiati98 commented Oct 18, 2023

Description

This PR updates the rules for contributing and improves the content in the docs as follows:

  • Updated the CONTRIBUTING.md.
  • Mentioned that we welcome contributions, but prioritizing SheSharp members and people from underrepresented groups in the CONTRIBUTING.md.
  • Restructured the pull_request_template.md to cover assigned issue.

Type of PR

  • ✨ Feature
  • 🐞 Bug fix
  • 📄 Documentation update
  • Others

Related Issue

N/A

Copy link
Contributor

@mariahlaqua mariahlaqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this @adiati98 . As I said on Slack, I want to take a little time to think on this.

I'm gonna let it marinate!

* Adjust wordings in Contributing section on README
* Restructure the pull_request_template.md to cover assigned issue
@adiati98 adiati98 marked this pull request as ready for review October 21, 2023 06:13
@adiati98 adiati98 merged commit 5e4a261 into shesharpnl:main Oct 21, 2023
@adiati98
Copy link
Collaborator Author

@mariahlaqua @saragerion I resctructured and made adjustment here based on what I did in knowledge-hub repo.

@adiati98 adiati98 deleted the chores/improve-docs branch October 21, 2023 06:15
Copy link
Contributor

@mariahlaqua mariahlaqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @adiati98 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants