New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added semantic description to social.media page #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @charlieintech ! Thanks for your contribution. Can you update the description:
- remove // from beginning
- mention SheSharp (e.g. "A place for SheSharp community members to share their social media links")
- maybe include a link to join our Slack (https://shesharp.co/slack) in the description, or a section for SheSharp socials with the website and Slack (this is an extra bonus and not required if you would just like it approved )
Let me know if you need further input. Thanks so much for contributing to our project!
|
Also hi @charlieintech ! I did #100Devs cohort two! nice to see another 100Devs-er here!! |
Hi @mariahlaqua ! I made changes and pushed the changes. Please let me know if I need to make any corrections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlieintech I left here some feedback π
socials/socials.md
Outdated
|
|
||
| #### Description | ||
|
|
||
| A place for SheSharp community members to share their social media links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| A place for SheSharp community members to share their social media links | |
| A place for SheSharp community members to share their social media links. |
|
Thanks for the help :) I think I updated it. Please let me know if there is anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come and join out community on [Slack] (https://shesharp.co/slack)
Can we fix this typo as well? Thanks again @charlieintech !!
Come and join our community on [Slack] (https://shesharp.co/slack)
|
Fixed typo :) |
|
Thank you @charlieintech ! π― |
Description
Type of PR
Related Issue