Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added semantic description to social.media page #31

Merged
merged 7 commits into from Oct 10, 2023

Conversation

charlieintech
Copy link
Contributor

Description

Type of PR

  • ✨ Feature
  • 🐞 Bug fix
  • [ X] πŸ“„ Documentation update
  • Others

Related Issue

Copy link
Contributor

@mariahlaqua mariahlaqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @charlieintech ! Thanks for your contribution. Can you update the description:

  • remove // from beginning
  • mention SheSharp (e.g. "A place for SheSharp community members to share their social media links")
  • maybe include a link to join our Slack (https://shesharp.co/slack) in the description, or a section for SheSharp socials with the website and Slack (this is an extra bonus and not required if you would just like it approved )

Let me know if you need further input. Thanks so much for contributing to our project!

@mariahlaqua
Copy link
Contributor

Also hi @charlieintech ! I did #100Devs cohort two! nice to see another 100Devs-er here!!

@charlieintech
Copy link
Contributor Author

charlieintech commented Oct 9, 2023

Hi @charlieintech ! Thanks for your contribution. Can you update the description:

  • remove // from beginning
  • mention SheSharp (e.g. "A place for SheSharp community members to share their social media links")
  • maybe include a link to join our Slack (https://shesharp.co/slack) in the description, or a section for SheSharp socials with the website and Slack (this is an extra bonus and not required if you would just like it approved )

Let me know if you need further input. Thanks so much for contributing to our project!

Hi @mariahlaqua ! I made changes and pushed the changes. Please let me know if I need to make any corrections.

Copy link
Collaborator

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlieintech I left here some feedback πŸ™‚

socials/socials.md Outdated Show resolved Hide resolved

#### Description

A place for SheSharp community members to share their social media links
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A place for SheSharp community members to share their social media links
A place for SheSharp community members to share their social media links.

socials/socials.md Outdated Show resolved Hide resolved
@charlieintech
Copy link
Contributor Author

Thanks for the help :) I think I updated it. Please let me know if there is anything else.

Copy link
Contributor

@mariahlaqua mariahlaqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come and join out community on [Slack] (https://shesharp.co/slack)

Can we fix this typo as well? Thanks again @charlieintech !!

Come and join our community on [Slack] (https://shesharp.co/slack)

@charlieintech
Copy link
Contributor Author

Fixed typo :)

@mariahlaqua
Copy link
Contributor

Thank you @charlieintech ! πŸ’―

@mariahlaqua mariahlaqua merged commit c8754bf into shesharpnl:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants