New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish module names #35

Open
io7m opened this Issue Feb 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@io7m
Copy link

io7m commented Feb 7, 2018

Hello!

Any chance you'll be publishing Automatic-Module-Name entries for the jcpp jar?

http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html

I'd suggest: Automatic-Module-Name: org.anarres.jcpp

@ooxi

This comment has been minimized.

Copy link

ooxi commented Feb 8, 2018

Could you provide a patch? This will increase the odds of integration significantly :-)

@io7m

This comment has been minimized.

Copy link
Author

io7m commented Feb 8, 2018

Yep, can do. I'll open a PR shortly.

io7m added a commit to io7m/jcpp that referenced this issue Feb 8, 2018

Add Automatic-Module-Name
This adds an Automatic-Module-Name entry to the produced jar for the
project. The chosen module name is "org.anarres.jcpp".

Fix shevek#35

@io7m io7m referenced a pull request that will close this issue Feb 8, 2018

Open

Add Automatic-Module-Name #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment