Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol Color Changable #138

Merged
merged 5 commits into from Aug 1, 2021
Merged

Symbol Color Changable #138

merged 5 commits into from Aug 1, 2021

Conversation

rhotav
Copy link
Contributor

@rhotav rhotav commented Jul 31, 2021

I couldn't find this feature while working on a project, then I had to make changes to Internal. Now we can change the symbol colors with the "DoneSymbolColor" and "PromptSymbolColor" properties on the ColorSchema class.
Screenshot_1

Sharprompt/Internal/OffscreenBuffer.cs Outdated Show resolved Hide resolved
Sharprompt/Prompt.Customize.cs Outdated Show resolved Hide resolved
@shibayan
Copy link
Owner

shibayan commented Aug 1, 2021

Thanks @rhotav. Naming conventions and C# code formatting will need to be changed.
The code format can be modified by running the dotnet format command.

rhotav and others added 2 commits August 1, 2021 11:14
Co-authored-by: Tatsuro Shibamura <me@shibayan.jp>
@rhotav rhotav requested a review from shibayan August 1, 2021 08:51
Copy link
Owner

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status check error needs to be resolved.

@rhotav
Copy link
Contributor Author

rhotav commented Aug 1, 2021

@shibayan I don't quite understand what to do? (I'm making a pull request for the first time, sorry)

@shibayan
Copy link
Owner

shibayan commented Aug 1, 2021

@rhotav This can be fixed by running dotnet format in the Sharprompt directory after installing the dotnet-format tool.

dotnet tool install -g dotnet-format
dotnet format

Here's an example of how it works (in Japanese)
image

@rhotav
Copy link
Contributor Author

rhotav commented Aug 1, 2021

@shibayan Okay, I got it and did it. thank you for your help

Copy link
Owner

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shibayan shibayan merged commit a83ca00 into shibayan:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants