Cannot filter retweets #13

Open
andrew-ledawson opened this Issue Mar 4, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@andrew-ledawson

Although the Python twitter API supports filtering out retweets, it is not currently possible to filter them in this utility. I suspect users (including myself) use the user argument to download photos posted by twitter users and might not care about retweeted photos that are not originally theirs.

@andrew-ledawson

This comment has been minimized.

Show comment
Hide comment
@andrew-ledawson

andrew-ledawson Mar 4, 2017

I have fixed this on my own branch, but it has slightly deviated from the original codebase, so it cannot be easily merged. Fortunately the changed are simple to replicate, here is the relevant commit: andrew-ledawson@653cebe

I missed some documentation which I fixed in another commit. I apologize for not offering a clean pull request, I'm still learning Git and good practices. Thanks for your time!

I have fixed this on my own branch, but it has slightly deviated from the original codebase, so it cannot be easily merged. Fortunately the changed are simple to replicate, here is the relevant commit: andrew-ledawson@653cebe

I missed some documentation which I fixed in another commit. I apologize for not offering a clean pull request, I'm still learning Git and good practices. Thanks for your time!

@andrew-ledawson

This comment has been minimized.

Show comment
Hide comment
@andrew-ledawson

andrew-ledawson Mar 4, 2017

I should also note that I have conducted basic tests on my fork and have found no issues including and excluding retweets.

I should also note that I have conducted basic tests on my fork and have found no issues including and excluding retweets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment