Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoudn't open the sidebar when it's hidden. #1

Closed
dummifiedme opened this issue Dec 21, 2020 · 9 comments
Closed

Shoudn't open the sidebar when it's hidden. #1

dummifiedme opened this issue Dec 21, 2020 · 9 comments

Comments

@dummifiedme
Copy link

@dummifiedme dummifiedme commented Dec 21, 2020

The plugin currently opens sidebar whenever I create a file. I know it is meant to reveal the file, but can it not really do that without opening the sidebar? It creates a distraction while writing.
Also, when using in a reduced window size it ceates a hassle to hide sidebar everytime I create or navigate a new page

@shichongrui
Copy link
Owner

@shichongrui shichongrui commented Dec 21, 2020

I'll take a look into seeing if I can detect if the sidebar is closed and not trigger the command.

@tonyxiao
Copy link

@tonyxiao tonyxiao commented Sep 20, 2021

+1 for thius

@MavropaliasG
Copy link

@MavropaliasG MavropaliasG commented Oct 1, 2021

+1, please @shichongrui !! It's really annoying

@nikolasetiawan
Copy link

@nikolasetiawan nikolasetiawan commented Oct 26, 2021

@mikkovedru
Copy link

@mikkovedru mikkovedru commented Oct 28, 2021

@shichongrui
I came here to suggest the same.

@Elaws
Copy link

@Elaws Elaws commented Jan 24, 2022

@dummifiedme : Great suggestion, came here to suggest this. Until this gets implemented, I'll have to revert back to using native shortcut to show only when desired. I set up the following shortcuts :

Ctrl + shift + H : Reveal active file in explorer.

(Not directly related, but these shortcuts are also quite useful :
Ctrl + shift + J : Hide/Reveal left sidebar.
Ctrl + shift + M : Hide/Reveal right sidebar.)

@anselmwang
Copy link
Contributor

@anselmwang anselmwang commented Mar 13, 2022

I have fixed this issue in this PR #9
Is anyone interested in trying it? I am happy to hear feedback and adjust the experience.

Current experience is:

  • When file explorer is visible, auto reveal
  • When file explorer is visible, disable auto reveal, so the sidebar will not auto popup. The reasons are two folds (as mentioned by @dummifiedme) : 1) the auto popup creates a distraction while writing. 2) when using in a reduced window size auto popup ceates a hassle to hide sidebar everytime I create or navigate a new page
  • When file explorer is changed from hidden to visible, auto reveal. So the experience is still very similar to original plugin. This behavior is especially useful on Mobile. The sidebar is hidden most of the time due to limit screen width. If I don't add the last behavior, auto reveal basically always disabled.

@mikkovedru
Copy link

@mikkovedru mikkovedru commented Mar 16, 2022

@anselmwang
I tested your PR and it works great. 👍 Thank you! 🥇

@shichongrui
Copy link
Owner

@shichongrui shichongrui commented Mar 16, 2022

Released as version 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants