Overflow-x on homepage #39

Closed
Danzibob opened this Issue Aug 24, 2016 · 5 comments

Projects

None yet

3 participants

@Danzibob

image
The rainbow image causes an overflow in the right-container. This can be solved by adding the overflow-x: hidden; property to the right-container

@shiffman shiffman added a commit that referenced this issue Aug 24, 2016
@shiffman fixing overflow thanks to #39 f257f64
@shiffman
Owner

I added it here f257f64 but am still seeing the scroll. Any ideas?

@Danzibob
Danzibob commented Aug 25, 2016 edited

The property appears to be being overwritten by the css on this page (http://shiffman.net/css/main.css) line 113. I'm no expert on scss so not sure where thats coming from. May be best just to overwrite it in index.html by adding style="overflow-x: hidden;" directly to the right-container element.

@shiffman
Owner

@scottwooden did I break something at some point? Can you advise on how I should fix this if you have a spare minute?

@DexterShepherd

@shiffman it looks like overflow-x is set to hidden on line 74 _layout.scss, but then reset overflow: scroll on line 570 of the same file. It doesn't seem like the overflow: scroll is needed anywhere so you should be able to delete line 570 and things will work again :)

@shiffman shiffman added a commit that referenced this issue Oct 31, 2016
@shiffman fixing scroll issue #39 4d5383c
@shiffman
Owner

thank you!!! Fixed!

@shiffman shiffman closed this Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment