#72 remove reflect metadata import #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reflect-metadata should only exist once in the whole code base of a project so the consumer of our library must import the reflect-metadata project, even if he might not use it in his code base. But if he uses the reflect-metadata in his code or uses another library like InversifyJS we must ensure the Reflect global variable only exists once, to prevent from possible hard to debug issues
somehow the tslint is not working when using with staged files matching the test glob
- update README to provide some more information about what is required to start to use dynamo-easy - adding comment with breaking change which I forgot to add previously BREAKING CHANGE all consumers of dynamo-easy must install and import reflect-metadata in their project.
Member
Author
|
closes #84 |
Member
Author
|
🎉 This PR is included in version 4.0.1-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
Author
|
🎉 This PR is included in version 4.1.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
Author
|
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
Author
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.