From a4b78e5c89ec5cd69f352db4831177b29a6dcfb1 Mon Sep 17 00:00:00 2001 From: jfgordon2 <55799997+jfgordon2@users.noreply.github.com> Date: Mon, 30 Mar 2020 12:06:52 -0500 Subject: [PATCH] polish About modal for Linux build (#241) Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page --- app/src/ui/about/about.tsx | 20 ++++++++++++++++++-- app/src/ui/lib/releases.ts | 1 + 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/app/src/ui/about/about.tsx b/app/src/ui/about/about.tsx index 6b6d5ac2ee3..9b2a0887512 100644 --- a/app/src/ui/about/about.tsx +++ b/app/src/ui/about/about.tsx @@ -14,7 +14,7 @@ import { Disposable } from 'event-kit' import { Loading } from '../lib/loading' import { RelativeTime } from '../relative-time' import { assertNever } from '../../lib/fatal-error' -import { ReleaseNotesUri } from '../lib/releases' +import { ReleaseNotesUri, LinuxReleasesUri } from '../lib/releases' import { encodePathAsUrl } from '../../lib/path' const DesktopLogo = encodePathAsUrl(__dirname, 'static/logo-64x64@2x.png') @@ -94,6 +94,17 @@ export class About extends React.Component { return null } + if (__LINUX__) { + const linuxReleaseLink = ( + View Releases + ) + return ( + +

{linuxReleaseLink}

+
+ ) + } + const updateStatus = this.state.updateState.status switch (updateStatus) { @@ -169,7 +180,12 @@ export class About extends React.Component { private renderUpdateDetails() { if (__LINUX__) { - return null + return ( +

+ Please visit the GitHub Desktop for Linux release page for + Linux-specific release notes and to download the latest version. +

+ ) } if ( diff --git a/app/src/ui/lib/releases.ts b/app/src/ui/lib/releases.ts index c9eb3a5b3b5..c6d0e0fa924 100644 --- a/app/src/ui/lib/releases.ts +++ b/app/src/ui/lib/releases.ts @@ -1 +1,2 @@ export const ReleaseNotesUri = 'https://desktop.github.com/release-notes/' +export const LinuxReleasesUri = 'https://github.com/shiftkey/desktop/releases/'