Skip to content

OSASINFRA-3918: posttriage: Remove check for Test coverage #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

OSASINFRA-3918: posttriage: Remove check for Test coverage #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions cmd/posttriage/checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,19 +122,3 @@ func TestCoverageFromIssue(issue jira.Issue) (testCoverage, error) {
return testCoverageNone, fmt.Errorf("unknown test coverage value: %s", testCoverageMap["id"])
}
}

func testCoverageCheck(issue jira.Issue) (bool, string, error) {
// If a bug has been closed as a non-bug, we shouldn't insist on test coverage.
if isNotBug(issue) {
return true, "", nil
}

tc, err := TestCoverageFromIssue(issue)
if err != nil {
return false, "", fmt.Errorf("failed to parse Test coverage: %w", err)
}
if tc == testCoverageNone {
return false, "the Test coverage assessment is missing", nil
}
return true, "", nil
}
1 change: 0 additions & 1 deletion cmd/posttriage/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func main() {
triageChecks := [...]triageCheck{
priorityCheck,
releaseBlockerCheck,
testCoverageCheck,
}

var (
Expand Down