Skip to content

OSASINFRA-3799: Use YAML for team data #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

OSASINFRA-3799: Use YAML for team data #95

merged 1 commit into from
May 14, 2025

Conversation

@pierreprinetti
Copy link
Contributor

@pierreprinetti pierreprinetti commented May 9, 2025

Use YAML files for human consumption. Also add a sprinkle of refactoring.

@openshift-ci openshift-ci bot requested review from mandre and stephenfin May 9, 2025 17:10
@openshift-ci openshift-ci bot added the approved label May 9, 2025
@pierreprinetti pierreprinetti marked this pull request as draft May 9, 2025 17:10
@pierreprinetti pierreprinetti marked this pull request as ready for review May 9, 2025 17:10
@openshift-ci openshift-ci bot requested review from EmilienM and dkokkino May 9, 2025 17:10
@pierreprinetti
Copy link
Contributor Author

pierreprinetti commented May 9, 2025

/hold not on a Friday

@pierreprinetti pierreprinetti force-pushed the address_book branch 3 times, most recently from f1ff7d3 to 839c338 Compare May 9, 2025 21:45
@pierreprinetti pierreprinetti changed the title Use YAML for team data OSASINFRA-3799: Use YAML for team data May 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 11, 2025 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3799 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Use YAML files for human consumption. Also add a sprinkle of refactoring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pierreprinetti
Copy link
Contributor Author

pierreprinetti commented May 11, 2025

/hold cancel

@pierreprinetti pierreprinetti force-pushed the address_book branch 2 times, most recently from 742cd61 to c27d3e8 Compare May 12, 2025 08:41
mandre
mandre reviewed May 12, 2025
View reviewed changes
@pierreprinetti pierreprinetti force-pushed the address_book branch 3 times, most recently from d8cd1b7 to 6129938 Compare May 13, 2025 10:57
mandre
mandre reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Contributor Author

pierreprinetti commented May 13, 2025

/hold

@pierreprinetti
Copy link
Contributor Author

pierreprinetti commented May 13, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the lgtm label May 13, 2025
@pierreprinetti pierreprinetti force-pushed the address_book branch 3 times, most recently from fd211d8 to 9183d9d Compare May 13, 2025 12:13
@pierreprinetti
Use YAML for team data
2c2fe6d 
Use YAML files for human consumption. Also add a sprinkle of
refactoring.
mandre
mandre reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2ec8a43 into main May 14, 2025
4 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the address_book branch May 14, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@stephenfin stephenfin Awaiting requested review from stephenfin

@dkokkino dkokkino Awaiting requested review from dkokkino

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@mandre mandre

Labels

approved jira/valid-reference lgtm

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreprinetti @openshift-ci-robot @mandre