Precompile builtin/*.sk #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corelib and ImportedItems are not the same
Vtables of foreign classes are needed to invoke its method
Lookup superclass in imported_classes too
Because it will be copied when subclassing a builtin class (especially, `Meta:A` inherits `Class` which has `@name`)
It seems that .ll is somewhat more "robust" than .bc. Suppose there is an instruction after `unreachable`. For .ll, llc can compile such .ll but for .bc, clang (and llvm-dis) raises error like `Invalid instruction with no BB`.
eg. ``` if true panic "" else panic "" end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #279
This PR caches compilation of builtin/*.sk into builtin/builtin.bc and builtin/exports.json.
builtin.bc contains LLVM bitcode and will be linked to main program with
clangcommand.exports.json contains information needed to compile the main program without reading builtin/*.sk. (JSON is used just for debugging purpose and is not intended to be modified in hand. We can change it to some binary format for better performance in the future.)