shilman
Follow
Pinned
3,976 contributions in the last year
Activity overview
Contributed to
storybookjs/storybook,
storybookjs/ember,
storybookjs/design-system
and 29 other
repositories
Contribution activity
March 2023
Created 192 commits in 5 repositories
Created 2 repositories
- shilman/storybook-docs-toc TypeScript
- shilman/astro TypeScript
Created a pull request in storybookjs/storybook that received 1 comment
Core: Fix default export storySort handling
Closes N/A
What I did
Previous code errored in the case where there was no options parameter at all.
Added a test case & fixed. Self-merging @ndela…
+64
−35
•
1
comment
Opened 19 other pull requests in 4 repositories
storybookjs/storybook
14
merged
2
closed
- Fix TS5 support in 6.5
- CLI: Fix sb add / mdx-gfm for addons with non-serializable values
- CSF-plugin: Fix sourcemaps
- React: Fix TS docgen for Functional Components
- Revert "CLI: Upgrade non-core storybook packages better"
- CLI: Upgrade non-core storybook packages better
- Story Index: Fix storySort parsing for parameters variable
- CLI: Copy tweaks for automigrations
- Telemetry: Is interactive shell
- CLI: Fix versions.ts to install latest prerelease packages
- Benchmark removing reactDocgen from React projects
- Upgrade react-docgen-typescript-plugin for TS4.8
- Core: Fix storySort parsing in preview.js with default export
- Rename AutoDocs to Autodocs
- Document MDX docs template
- CLI: Fix formatting of autodocs-true automigration
storybookjs/react-docgen-typescript-plugin
1
open
shilman/react-docgen-typescript-plugin
1
open
storybookjs/react-docgen-typescript
1
open
Reviewed 37 pull requests in 4 repositories
storybookjs/storybook
25 pull requests
-
Make
transformSource API consistent - Docs: Exclude decorators by default from source
- Docs: Allow dark theme in fenced code blocks
- React: Fix missing framework options in shim
- improve blocks error messages
- UI: Default white preview background
- CLI: Don't inline template functions in CSF2 to 3 codemod
- Build: Add e2e-tests-dev task
- CLI: Fix MDX codemod to update imports even when no stories are extracted
- CLI: Filter out internal static dir logging
- Core: Fix project root detection in yarn PnP without git
- Docs: Error if you try to index an MDX file in ssv6
- Telemetry: Replace isomorphic-unfetch with node-fetch in telemetry
- Core: Fix builders/renderer PnP support
- CLI: Require main.js without cache in automigrations
- Core: Change warnings to throwing when hitting duplicates in the index
- CLI: Copy tweaks for automigrations
- Vite: Add react docgen types
-
Core: Print errors in
withTelemetrybefore prompting - Docs: Use async import rather than require in docs
- Docs: Don't warn if we find the same entry twice.
- Telemetry: Ensure we report errors even when unexpected things happen
- CLI: Fix versions.ts to install latest prerelease packages
- Docs: Show MDX errors using our error overlay
-
Docs: Update invalid
<Meta of={}>error to be more helpful. - Some pull request reviews not shown.
storybookjs/mdx1-csf
1 pull request
storybookjs/mdx2-csf
1 pull request
storybookjs/addon-kit
1 pull request
Created an issue in storybookjs/storybook that received 8 comments
[Bug]: Critical dependency: require function is used in a way in which dependencies cannot be statically extracted.
Describe the bug After migrating, I get HMR warnings in the browser regarding @storybook/react @storybook/addon-docs Like so: ./node_modules/@st…
8
comments
Opened 16 other issues in 1 repository
storybookjs/storybook
9
closed
7
open
- [Bug]: Cannot destructure property 'legacyRootApi' of '(intermediate value)' as it is undefined.
- SB7 migration support for previous MDX+CSF recipes
- [Bug]: Frameworks automigration misses builder options
- [Bug]: NextJS automigration misses static paths
- [Bug]: Extra divider shown in toolbar when zoom controls are not shown
- UI: Don't show toolbar addons in pure MDX pages
- [Bug]: Yarn PnP mode fails to parse typescript
- [Bug]: Cannot destructure property 'preprocess' of 'svelteOptions' as it is undefined.
- [Bug]: Unable to index files: Duplicate stories with id: example-button--primary
- [Bug]: Performance regression in Astro UXDS
- [Bug]: Fix mdx-to-csf codemod blocks imports
- [Bug]: Thrown errors unreported
- [Bug]: runtime.mjs was preloaded using link preload but not used within a few seconds from the window's load event
- [Bug]: Nunito-sans-italic preloaded using link preload but not used within a few seconds from the window's load event
- [Bug]: Error handling for Vite 2.x
- CLI: Fix telemetry prompt to show after error display
4
contributions
in private repositories
Mar 11 – Mar 14