Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce-terminal has extra pixel border with >1 tab #184

Closed
ochosi opened this issue Apr 25, 2017 · 11 comments

Comments

Projects
None yet
4 participants
@ochosi
Copy link
Member

commented Apr 25, 2017

Full issue described here (incl screenshot).
https://bugs.launchpad.net/bugs/1683857

@casta

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

confirmed with xfce4-terminal (last git revision), and having the same with mate-terminal (1.16) too.
Too bad, I cannot achieve to run gtk3 inspector on terminal apps to dig into the css selectors. It’s strangely not working (not able to select any window component on the terminal).

@f2404

This comment has been minimized.

Copy link

commented May 31, 2017

It appears there's an ancient bug against xfce4-terminal for that :) https://bugzilla.xfce.org/show_bug.cgi?id=3244
But, since this also happens with mate-terminal and gnome-terminal, I'm not sure whether it's a terminal issue.

@casta

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

moreover it does not happen with other themes (like Zukitwo for example), and the old bug is related to gtk2, this one is for gtk3 too

@casta

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

I have something that seems to work. Adding this to the .config/gtk-3.0/gtk.css fixes the issue:

notebook > stack:not(:only-child) {
  border: 0;
}
notebook > header.top tabs {
  margin-bottom: 0;
}
notebook > header.bottom tabs {
  margin-top: 0;
}
notebook > header.left tabs {
  margin-right: 0;
}
notebook > header.right tabs {
  margin-left: 0;
}

It looks like the issue is Greybird setting a 1px border on notebook > stack:not(:only-child) where it should only do this on the notebook side having the tabs.

casta added a commit to casta/Greybird that referenced this issue Jun 12, 2017

@ochosi ochosi closed this in #192 Jun 12, 2017

ochosi added a commit that referenced this issue Jun 12, 2017

@f2404

This comment has been minimized.

Copy link

commented Jan 19, 2019

The pixel seems to be back again - please see https://bugzilla.xfce.org/show_bug.cgi?id=15025
Adwaita doesn't add it so I suppose something has changed within GTK that now needs to be reflected in Greybird.
Thanks!

@f2404

This comment has been minimized.

Copy link

commented Jan 19, 2019

Actually, the css code above still seems to be working when put to ~/.config/gtk-3.0/gtk.css. How comes it doesn't work in the theme?

@aib

This comment has been minimized.

Copy link

commented Jan 20, 2019

The workaround indeed works (though one has to close all instances of the terminal), as does putting the code in /usr/share/themes/Greybird/gtk-3.0/gtk-contained.css (around line 2554, right before the "Scrollbars" section).

What I don't understand is how my up-to-date Ubuntu Budgie still has the bug. (greybird-gtk-theme at 3.22.9-0ubuntu1). Oh, there it is:

https://github.com/shimmerproject/Greybird/blob/master/gtk-3.0/gtk-contained.css#L2556

@f2404

This comment has been minimized.

Copy link

commented Jan 20, 2019

Indeed, commenting out line 2556 seems to solve the issue.
The line was added as part of 8e74c38

@f2404

This comment has been minimized.

Copy link

commented Jan 28, 2019

Ping @ochosi

@ochosi

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

@f2404 If you try to simply remove that line a lot of other applications are broken, e.g. pavucontrol starts to look quite terrible. I'll push a fix specifically for xfce4-terminal.

@f2404

This comment has been minimized.

Copy link

commented Feb 9, 2019

@ochosi Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.