Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfwm 4.13.1 tabwin as list too sparse #224

Closed
andreldm opened this issue Aug 21, 2018 · 11 comments

Comments

Projects
None yet
2 participants
@andreldm
Copy link

commented Aug 21, 2018

Until now Xfwm 4.13.1 tabwin was missing proper Greybird style, it looks great when using the default icon mode, but when "Cycle through windows in a list" is enabled in Window Manager Tweaks, it looks too sparse:

image

@ochosi

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

Oh my, I guess I would have to patch Xfwm4 to properly fix this...

Currently there is no meaningful way to distinguish the list and the normal style, at least not in CSS. I will take a look at Xfwm4 I guess.

@andreldm

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

I don't think so, you just forgot about listview-icon-size, all you need is to add -XfwmTabwinWidget-listview-icon-size: 24px; to #xfwm-tabwin.

@andreldm

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

Oh, min-width and min-height in #xfwm-tabwin button need to be removed or decreased to 24px.

@ochosi

This comment has been minimized.

Copy link
Member

commented Aug 25, 2018

Yeah, I know and that's not a very nice solution. It would be nicer if Xfwm4 would set an additional styleclass dynamically when the list mode is in use

@andreldm

This comment has been minimized.

Copy link
Author

commented Aug 25, 2018

Both properties (icon-size and listview-icon-size) are used in the gtk2 version of Greybird, I fail to see how this is not a nice solution for gtk3. At least both modes now look fine to me.
I know styleclasses would be safer and simple to introduce in xfwm4, but is it really necessary?

@ochosi

This comment has been minimized.

Copy link
Member

commented Aug 26, 2018

If you want to use something like min-height, then yes. Personally I like that in Gtk3 I can make those buttons a tad bigger and enforce squareness.

@andreldm

This comment has been minimized.

Copy link
Author

commented Aug 28, 2018

@ochosi ochosi closed this in 358912c Sep 13, 2018

@ochosi

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

Until we get this fixed in Xfwm4 I don't want to leave everyone using Xfwm4 with listview and Greybird in the rain. I can always re-introduce this style again later.

@andreldm

This comment has been minimized.

Copy link
Author

commented Feb 6, 2019

@ochosi ochosi reopened this Feb 8, 2019

@ochosi

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Thanks @andreldm, I'll take a look at this again soon.

@ochosi

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Works nicely with git master! Thanks for the patch.

@ochosi ochosi closed this Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.