Permalink
Browse files

small cleanup / spelling fixes

  • Loading branch information...
1 parent d8be65b commit 26eaa7c2f9dd8ad68d26a00d57553f08d04637e9 @squentin squentin committed May 28, 2009
Showing with 7 additions and 12 deletions.
  1. +1 −1 INSTALL
  2. +1 −1 gmusicbrowser_list.pm
  3. +5 −10 oggheader.pm
View
@@ -1,6 +1,6 @@
First, check your distribution's repository to see if there is an up-to-date package.
-You can run gmusicbrowser without installation by simply running decompressing the .tar.gz and running gmusicbrowser.pl, either with a relative path :
+You can run gmusicbrowser without installation by simply decompressing the .tar.gz and running gmusicbrowser.pl, either with a relative path :
./gmusicbrowser.pl
or gmusicbrowser-VERSION/gmusicbrowser.pl
or with an absolute path :
View
@@ -2006,7 +2006,7 @@ package FilterList;
use Gtk2;
use base 'Gtk2::VBox';
use constant { GID_ALL => 65535, GID_TYPE => 'Glib::UInt' };
-#use constant { GID_ALL => 2**32-1, GID_TYPE => 'Glib::ULong' }; #to suuport more than 65534 artist/albums/...
+#use constant { GID_ALL => 2**32-1, GID_TYPE => 'Glib::ULong' }; #to suport more than 65534 artist/albums/...
sub new
{ my ($class,$field,$opt1,$opt2,$pid)=@_;
View
@@ -104,7 +104,7 @@ INIT
# serial serial number (binary 4 bytes)
# seg_table segmentation table of last read page
# granule granule of last read page
-# info -> hash containing : version channels rate bitrate_upper bitrate_nominal bitrate_lower seconds mmss
+# info -> hash containing : version channels rate bitrate_upper bitrate_nominal bitrate_lower seconds
# comments -> hash of arrays
# CommentsOrder -> list of keys
# commentpack_size
@@ -117,7 +117,6 @@ sub new
{ my ($class,$file)=@_;
my $self=bless {}, $class;
- local $_;
# check that the file exists and is readable
unless ( -e $file && -r $file )
{ warn "File '$file' does not exist or cannot be read.\n";
@@ -143,7 +142,7 @@ sub new
my $l=0;
$l=$l*256+$_ for reverse @granule;
$self->{info}{seconds}=my$s=$l/$self->{info}{rate};
- $self->{info}{mmss}=sprintf '%d:%02d',$s/60,$s%60;
+ #$self->{info}{mmss}=sprintf '%d:%02d',$s/60,$s%60;
#warn "length : ".$self->{info}{mmss}."\n";
}
@@ -189,9 +188,8 @@ sub _close
close delete($self->{fileHandle});
}
-sub write_file # experimental
+sub write_file
{ my $self=shift;
- local $_;
my $newcom_packref=_PackComments($self);
#warn "old size $self->{commentpack_size}, need : ".length($$newcom_packref)."\n";
if ( $self->{commentpack_size} >= length $$newcom_packref)
@@ -320,11 +318,8 @@ sub _ReadInfo
# 8) [blocksize_1] = 2 exponent (read 4 bits as unsigned integer)
# 9) [framing_flag] = read one bit
if ( my $packref=_read_packet($self,PACKET_INFO) )
- { @_=unpack 'x7 VCV V3 C',$$packref;
- my %info;
- #print "info : ".join(' ',@_)."\n";
- $info{$_}=shift @_
- for (qw/version channels rate bitrate_upper bitrate_nominal bitrate_lower/);
+ { my %info;
+ @info{qw/version channels rate bitrate_upper bitrate_nominal bitrate_lower/}= unpack 'x7 VCV V3 C',$$packref;
return \%info;
}
else

0 comments on commit 26eaa7c

Please sign in to comment.