New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sound toggle bug #591

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@ornoone
Contributor

ornoone commented Oct 13, 2017

version

Shinken 2.4.3 — Web User Interface 2.6.1,

page

all (bug in layout)

expected behavior

when i click on the toggle sound icon, it should enable the sound, and change the icon of the button to remove the .fa-ban

current behavior

clicking on the button do absolutly nothing.

fix

I found in shinken-layout.js that the block that manage the event on this button is surounded by a If which check if a outdated ID exists. i fix it by changing this query by id #alert-audio with a query by class .js-toggle-sound-alert which target the same item, and is uniq.

@maethor

This comment has been minimized.

Show comment
Hide comment
@maethor

maethor Oct 16, 2017

Contributor

Sound good to me. Thank you @ornoone !

Contributor

maethor commented Oct 16, 2017

Sound good to me. Thank you @ornoone !

@maethor maethor merged commit ef5f2e3 into shinken-monitoring:develop Oct 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ornoone ornoone deleted the Yupeek:fix-sound-toggle branch Oct 17, 2017

@maethor

This comment has been minimized.

Show comment
Hide comment
@maethor

maethor Oct 19, 2017

Contributor

@ornoone 2.7.0 is now published, with this patch. Thanks again :)

Contributor

maethor commented Oct 19, 2017

@ornoone 2.7.0 is now published, with this patch. Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment