New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sound icon missplacement due to span.fa-stack #592

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@ornoone
Contributor

ornoone commented Oct 16, 2017

it seem this is the only button with this css issue. I reset the padding
to prevent the icon to be missplaced.

before

screenshot-shinken hominis int-2017-10-16-12-09-10

after css fix

screenshot-shinken hominis int-2017-10-16-12-11-34

fix sound icon missplacement due to span.fa-stack
it seem this is the only button with this css issue. I reset the padding
to prevent the icon to be missplaced.
@maethor

This comment has been minimized.

Show comment
Hide comment
@maethor

maethor Oct 17, 2017

Contributor

Thank you @ornoone !

Contributor

maethor commented Oct 17, 2017

Thank you @ornoone !

@maethor maethor merged commit 7804098 into shinken-monitoring:develop Oct 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ornoone ornoone deleted the Yupeek:fix-sound-notif-ico branch Oct 17, 2017

@maethor

This comment has been minimized.

Show comment
Hide comment
@maethor

maethor Oct 19, 2017

Contributor

@ornoone 2.7.0 is now published, with this patch. Thanks again :)

Contributor

maethor commented Oct 19, 2017

@ornoone 2.7.0 is now published, with this patch. Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment