Conversation
For the table and key_value backends, this means the model itself is touched when updating a translation.
MySQL's default precision isn't enough to change the updated_at otherwise.
Because we're touching when attributes are changed, this sometimes means these hashes will include updated_at (it appears to vary based on DB and Rails version).
Right now, we're only using them for testing with activerecord. If we need to use them with sequel, we can add as an explicit dependency.
shioyama
approved these changes
Sep 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the table and key_value backends, this means the model itself is touched when updating a translation.
Fixes #101. Closes #103.