New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support added AR::Dirty methods #111

Merged
merged 6 commits into from Nov 29, 2017

Conversation

Projects
None yet
1 participant
@shioyama
Owner

shioyama commented Nov 27, 2017

Fixes #106

@shioyama shioyama changed the title from [WIP] Support added AR::Dirty methods to Support added AR::Dirty methods Nov 28, 2017

@shioyama

This comment has been minimized.

Show comment
Hide comment
@shioyama

shioyama Nov 28, 2017

Owner

@brianstorti Here's a PR which adds saved_changes as well as other AR::Dirty attribute methods. I'm a bit concerned about the transition to AR 5.2, since dirty specs are currently already all failing, but in any case the specs added here should be useful, even if the code has to change in the next version.

Have a try and see what you think.

Owner

shioyama commented Nov 28, 2017

@brianstorti Here's a PR which adds saved_changes as well as other AR::Dirty attribute methods. I'm a bit concerned about the transition to AR 5.2, since dirty specs are currently already all failing, but in any case the specs added here should be useful, even if the code has to change in the next version.

Have a try and see what you think.

shioyama added some commits Nov 27, 2017

@shioyama

This comment has been minimized.

Show comment
Hide comment
@shioyama

shioyama Nov 29, 2017

Owner

So good news is that the changes in AR 5.2 don't seem to be related to the added methods here. Bad news is that I haven't got a good solution for them yet... but I'll merge this PR later today since it seems to work fine, and I don't think it will add any issues to fixing the 5.2 issues.

Owner

shioyama commented Nov 29, 2017

So good news is that the changes in AR 5.2 don't seem to be related to the added methods here. Bad news is that I haven't got a good solution for them yet... but I'll merge this PR later today since it seems to work fine, and I don't think it will add any issues to fixing the 5.2 issues.

@shioyama shioyama merged commit 7b9c631 into master Nov 29, 2017

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@shioyama shioyama deleted the saved_changes branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment