Skip to content

Support added AR::Dirty methods#111

Merged
shioyama merged 6 commits into
masterfrom
saved_changes
Nov 29, 2017
Merged

Support added AR::Dirty methods#111
shioyama merged 6 commits into
masterfrom
saved_changes

Conversation

@shioyama

Copy link
Copy Markdown
Owner

Fixes #106

@shioyama shioyama force-pushed the saved_changes branch 2 times, most recently from 0903aaf to 98d7260 Compare November 28, 2017 02:18
@shioyama shioyama changed the title [WIP] Support added AR::Dirty methods Support added AR::Dirty methods Nov 28, 2017
@shioyama

Copy link
Copy Markdown
Owner Author

@brianstorti Here's a PR which adds saved_changes as well as other AR::Dirty attribute methods. I'm a bit concerned about the transition to AR 5.2, since dirty specs are currently already all failing, but in any case the specs added here should be useful, even if the code has to change in the next version.

Have a try and see what you think.

@shioyama

Copy link
Copy Markdown
Owner Author

So good news is that the changes in AR 5.2 don't seem to be related to the added methods here. Bad news is that I haven't got a good solution for them yet... but I'll merge this PR later today since it seems to work fine, and I don't think it will add any issues to fixing the 5.2 issues.

@shioyama shioyama merged commit 7b9c631 into master Nov 29, 2017
@shioyama shioyama deleted the saved_changes branch November 30, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant