Refactor backend cache #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
refactor_cache
branch
4 times, most recently
from
1143108 to
83cf416
Compare
This commit restructures the current cache to allow the backend to customize the included module, simplifying greatly the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is unnecessarily complicated. This PR simplifies things so that backends can include a custom module through an
apply_modulehook. This allows KeyValue and Table backends to modify the Cache module they use just slightly to achieve the same result.A module builder called
TranslationCacheris shared by all cacheing strategies to cache reads; the only difference is which method is cached: in the default Cache module,readis cached; in KeyValue and Table backends,translation_foris cached (so that the translation record itself is cached, rather than the translation value).