Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobility/core_ext #60

Merged
merged 4 commits into from Aug 5, 2017
Merged

Remove mobility/core_ext #60

merged 4 commits into from Aug 5, 2017

Conversation

@shioyama
Copy link
Owner

shioyama commented Jul 27, 2017

Mobility adds methods like String#present?, String#blank?, String#presence if ActiveSupport is not loaded, but this is probably not a great idea in general. This PR will remove them and replace them with local methods which do not require patching String or Object.

@shioyama shioyama force-pushed the remove_camelize branch 2 times, most recently from 6072351 to d012b32 Jul 27, 2017
@shioyama shioyama force-pushed the remove_camelize branch 4 times, most recently from cedbfda to ebaaa26 Aug 5, 2017
@shioyama shioyama force-pushed the remove_camelize branch from ebaaa26 to 47cfbb6 Aug 5, 2017
@shioyama shioyama merged commit 47cfbb6 into master Aug 5, 2017
3 checks passed
3 checks passed
codeclimate 4 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@shioyama shioyama deleted the remove_camelize branch Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.