New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move accessor method to keyword argument in Attributes #72

Merged
merged 1 commit into from Aug 12, 2017

Conversation

Projects
None yet
1 participant
@shioyama
Owner

shioyama commented Aug 12, 2017

Currently Mobility::Attributes takes a method argument followed by one or more attribute names, but since in 99% of cases the method argument is :accessor, it makes more sense to bump this to the keyword arguments (with a default of method: :accessor), and just take a list of attributes.

@shioyama shioyama merged commit e1f2987 into master Aug 12, 2017

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@shioyama shioyama deleted the attributes_method_as_keyword_option branch Aug 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment