Skip to content

Extract injectThinkingTokens helper #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentShipsIt merged 1 commit into from
May 8, 2026
Merged

Extract injectThinkingTokens helper #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions packages/agents/src/providers/cli-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,21 @@ async function runCli(
});
}

function injectThinkingTokens(args: string[], req: ProviderRequest): void {
const tokens = mapReasoningEffortToClaudeThinkingTokens(
req.phaseHints?.reasoningEffort,
req.modelHint,
);
if (tokens !== null) {
args.splice(
args.indexOf('--dangerously-skip-permissions'),
0,
'--max-thinking-tokens',
String(tokens),
);
}
}

/** Build claude CLI args/stdin for a given phase. */
function buildClaudeCommand(req: ProviderRequest): CliCommand {
const modelArgs = req.modelHint ? ['--model', req.modelHint] : [];
Expand All @@ -166,10 +181,6 @@ function buildClaudeCommand(req: ProviderRequest): CliCommand {
// drawer can display reasoning blocks. Token budget is controlled by
// phaseHints.reasoningEffort (high=32000, medium=8000, low=omit).
const maxTurns = String(req.phaseHints?.maxTurns ?? 1);
const thinkingTokens = mapReasoningEffortToClaudeThinkingTokens(
req.phaseHints?.reasoningEffort,
req.modelHint,
);
const args = [
'-p',
...modelArgs,
Expand All @@ -182,14 +193,7 @@ function buildClaudeCommand(req: ProviderRequest): CliCommand {
'--disallowedTools',
'Edit,Write,Bash,NotebookEdit',
];
if (thinkingTokens !== null) {
args.splice(
args.indexOf('--dangerously-skip-permissions'),
0,
'--max-thinking-tokens',
String(thinkingTokens),
);
}
injectThinkingTokens(args, req);
return { args, stdin: req.prompt };
}
case 'execute': {
Expand All @@ -201,18 +205,7 @@ function buildClaudeCommand(req: ProviderRequest): CliCommand {
'Edit,Write,Bash,Glob,Grep,Read',
'--dangerously-skip-permissions',
];
const execThinking = mapReasoningEffortToClaudeThinkingTokens(
req.phaseHints?.reasoningEffort,
req.modelHint,
);
if (execThinking !== null) {
execArgs.splice(
execArgs.indexOf('--dangerously-skip-permissions'),
0,
'--max-thinking-tokens',
String(execThinking),
);
}
injectThinkingTokens(execArgs, req);
return { args: execArgs, stdin: req.prompt };
}
case 'review':
Expand Down
Loading