diff --git a/pkg/controller/buildrun/generate_taskrun.go b/pkg/controller/buildrun/generate_taskrun.go index d3866188d..17c218ede 100644 --- a/pkg/controller/buildrun/generate_taskrun.go +++ b/pkg/controller/buildrun/generate_taskrun.go @@ -258,12 +258,7 @@ func GenerateTaskRun( expectedTaskRun.Labels[label] = value } - // assign the timeout - if buildRun.Spec.Timeout != nil { - expectedTaskRun.Spec.Timeout = buildRun.Spec.Timeout - } else if build.Spec.Timeout != nil { - expectedTaskRun.Spec.Timeout = build.Spec.Timeout - } + expectedTaskRun.Spec.Timeout = effectiveTimeout(build, buildRun) var inputParams []v1beta1.Param if build.Spec.BuilderImage != nil { @@ -297,3 +292,14 @@ func GenerateTaskRun( expectedTaskRun.Spec.Params = inputParams return expectedTaskRun, nil } + +func effectiveTimeout(build *buildv1alpha1.Build, buildRun *buildv1alpha1.BuildRun) *metav1.Duration { + if buildRun.Spec.Timeout != nil { + return buildRun.Spec.Timeout + + } else if build.Spec.Timeout != nil { + return build.Spec.Timeout + } + + return nil +}