From 1951f7c25dec70474f8e3c89d4fb6eee8f33e70c Mon Sep 17 00:00:00 2001 From: Jason Hall Date: Thu, 4 Feb 2021 10:34:30 -0500 Subject: [PATCH] Don't retry flakes in integration tests Flaky behavior can hurt real users, and ignoring it to appease CI tests only hides the problem, and can make CI tests take longer. If this is too noisy, we can either spend effort fixing flakes, and/or make tests less strict, or re-enable flaky retries. --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 101159ec0..097c30bed 100644 --- a/Makefile +++ b/Makefile @@ -33,7 +33,7 @@ TEKTON_VERSION ?= v0.20.1 SDK_VERSION ?= v0.17.0 # E2E test flags -TEST_E2E_FLAGS ?= -failFast -flakeAttempts=2 -p -randomizeAllSpecs -slowSpecThreshold=300 -timeout=30m -progress -stream -trace -v +TEST_E2E_FLAGS ?= -failFast -p -randomizeAllSpecs -slowSpecThreshold=300 -timeout=30m -progress -stream -trace -v # E2E test operator behavior, can be start_local or managed_outside TEST_E2E_OPERATOR ?= start_local @@ -219,7 +219,6 @@ test-integration: install-apis ginkgo -randomizeAllSpecs \ -randomizeSuites \ -failOnPending \ - -flakeAttempts=2 \ -slowSpecThreshold=240 \ -trace \ test/integration/...