New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load CA certificates from system certificate store #395

Merged
merged 50 commits into from Nov 18, 2018

Conversation

Projects
None yet
3 participants
@qykth-git
Copy link
Contributor

qykth-git commented Nov 17, 2018

Load CA certificates from system certificate store. See also #365 .
It works on Windows with mbed TLS.

Usage:

# Use configure script
./configure --with-ca-bundle=system

or

;; Runtime configuration
(use rfc.tls)
(default-tls-class <mbed-tls>)
(tls-ca-bundle-path 'system)

@qykth-git qykth-git changed the title Load CA certificate from system certificate store Load CA certificates from system certificate store Nov 17, 2018

@shirok

This comment has been minimized.

Copy link
Owner

shirok commented Nov 18, 2018

Looks good. Thanks.

@shirok shirok merged commit dc81477 into shirok:master Nov 18, 2018

1 check passed

ci/inspecode/pr 224 issues detected.
Details
@Hamayama

This comment has been minimized.

Copy link
Contributor

Hamayama commented Nov 26, 2018

src/paths.c についてですが、
GAUCHE_CONFIG_C が設定されているときに
gauche.h をインクルードしないようになったため、
その下で GAUCHE_WINDOWS が未定義となり
getdir_dummy.c がインクルードされてしまうようです。
(Windows 8.1 で確認)

@shirok

This comment has been minimized.

Copy link
Owner

shirok commented Nov 26, 2018

Hmm, it was chaged in 9995d30

@qykth-git , what was the reason to avoid including gauche.h in gauche-config.c?

@shirok

This comment has been minimized.

Copy link
Owner

shirok commented Nov 27, 2018

gauche-config.cからpaths.cをインクルードする際に#include gauche.hを避ける必要に思い当たらないので、そこだけrevertしておきます。

shirok added a commit that referenced this pull request Nov 27, 2018

@qykth-git

This comment has been minimized.

Copy link
Contributor

qykth-git commented Nov 28, 2018

@shirok
この変更はクロスコンパイルを行なった時の変更です。
クロスコンパイル時は、build hostで動作する特製のgauche-configを作成するのですが、gauche.hは読み込むファイルの関係からセルフコンパイルでしか動作しないため、このような変更を行いました。
もっと良い方法が有ればそれで良いと思います。

@shirok

This comment has been minimized.

Copy link
Owner

shirok commented Nov 28, 2018

あーなるほど。ということはGAUCHE_WINDOWSをターゲットで切り替えるヘッダを別に用意すべきかな

@shirok

This comment has been minimized.

Copy link
Owner

shirok commented Dec 1, 2018

paths.cの問題は#401でトラックします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment