New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iform->sexpr ignore identifiers #90

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Sep 8, 2015

Before

gosh> (macroexpand-all '(cut print <>))
(lambda (|#<identifier srfi-26#x.e82d20>.0|) (print |#<identifier srfi-26#x.e82d20>.0|))
gosh> (macroexpand-all '((cut print <>) 1))
(letrec ((|#<identifier srfi-26#x.e821c0>.0| '1)) (print |#<identifier srfi-26#x.e821c0>.0|))

After

gosh> (macroexpand-all '(cut print <>))
(lambda (x) (print x))
gosh> (macroexpand-all '((cut print <>) 1))
(letrec ((x '1)) (print x))
@shirok

This comment has been minimized.

Show comment
Hide comment
@shirok

shirok Sep 8, 2015

Owner

The ".0" part is crucial and shouldn't be dropped, for it needs to distinguish same local name with different bindings. So I'd like to have it as

(lambda (x.0) (print x.0))

etc.

Owner

shirok commented Sep 8, 2015

The ".0" part is crucial and shouldn't be dropped, for it needs to distinguish same local name with different bindings. So I'd like to have it as

(lambda (x.0) (print x.0))

etc.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 9, 2015

I misunderstood. How do you think about the next change?

ghost commented Sep 9, 2015

I misunderstood. How do you think about the next change?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 9, 2015

gosh> (macroexpand-all '(cut print <>))
(lambda (x.0) (print x.0))
gosh> (macroexpand-all '((cut print <>) 1))
(letrec ((x.0 '1)) (print x.0))

ghost commented Sep 9, 2015

gosh> (macroexpand-all '(cut print <>))
(lambda (x.0) (print x.0))
gosh> (macroexpand-all '((cut print <>) 1))
(letrec ((x.0 '1)) (print x.0))
@shirok

This comment has been minimized.

Show comment
Hide comment
@shirok

shirok Sep 9, 2015

Owner

Looks ok. Let me test it locally before merge. Thanks!

Owner

shirok commented Sep 9, 2015

Looks ok. Let me test it locally before merge. Thanks!

@shirok

This comment has been minimized.

Show comment
Hide comment
@shirok

shirok Sep 10, 2015

Owner

Works great. Merged. Thanks!

Owner

shirok commented Sep 10, 2015

Works great. Merged. Thanks!

@shirok shirok closed this Sep 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment