From 066cef88b29b5ddfa108ce8520f3b45436ac0866 Mon Sep 17 00:00:00 2001 From: Sagar <99425694+sgup432@users.noreply.github.com> Date: Wed, 4 Jan 2023 10:55:18 -0800 Subject: [PATCH] Adding connection read timeout to prevent indefinite wait (#354) Signed-off-by: Sagar Upadhyaya Signed-off-by: Sagar Upadhyaya --- .../config/PerformanceAnalyzerResourceProvider.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/java/org/opensearch/performanceanalyzer/http_action/config/PerformanceAnalyzerResourceProvider.java b/src/main/java/org/opensearch/performanceanalyzer/http_action/config/PerformanceAnalyzerResourceProvider.java index 231c9703..5c33836f 100644 --- a/src/main/java/org/opensearch/performanceanalyzer/http_action/config/PerformanceAnalyzerResourceProvider.java +++ b/src/main/java/org/opensearch/performanceanalyzer/http_action/config/PerformanceAnalyzerResourceProvider.java @@ -44,6 +44,7 @@ public class PerformanceAnalyzerResourceProvider extends BaseRestHandler { LogManager.getLogger(PerformanceAnalyzerResourceProvider.class); private static final int HTTP_CLIENT_CONNECTION_TIMEOUT_MILLIS = 200; + private static final int HTTP_READ_CONNECTON_TIMEOUT_MILLIS = 10000; private static final String AGENT_PATH = RestConfig.PA_BASE_URI + "/_agent/"; private static final String LEGACY_AGENT_PATH = RestConfig.LEGACY_PA_BASE_URI + "/_agent/"; private static final String DEFAULT_PORT_NUMBER = "9600"; @@ -202,12 +203,14 @@ protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient cli private HttpURLConnection createHttpsURLConnection(URL url) throws IOException { HttpsURLConnection httpsURLConnection = (HttpsURLConnection) url.openConnection(); httpsURLConnection.setConnectTimeout(HTTP_CLIENT_CONNECTION_TIMEOUT_MILLIS); + httpsURLConnection.setReadTimeout(HTTP_READ_CONNECTON_TIMEOUT_MILLIS); return httpsURLConnection; } private HttpURLConnection createHttpURLConnection(URL url) throws IOException { HttpURLConnection httpURLConnection = (HttpURLConnection) url.openConnection(); httpURLConnection.setConnectTimeout(HTTP_CLIENT_CONNECTION_TIMEOUT_MILLIS); + httpURLConnection.setReadTimeout(HTTP_READ_CONNECTON_TIMEOUT_MILLIS); return httpURLConnection; }