PR #1: DSL IR Extension & Keyword Argument Parsing #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the foundation for argument value checking by: 1. Extended CallMatcherIR with ArgumentConstraint and KeywordArgs - Added ArgumentConstraint struct to represent argument value constraints - Added KeywordArgs field to CallMatcherIR (with omitempty for backward compat) - Supports single values and lists of values (OR logic) - Includes wildcard flag for pattern matching 2. Implemented parseKeywordArguments() function - Extracts keyword arguments from CallSite.Arguments - Handles "key=value" format parsing - Trims whitespace from keys and values - Supports complex values (nested objects, URLs with =) - O(N) performance where N = number of arguments 3. Added comprehensive unit tests (10 tests, 100% coverage) - Empty arguments - Positional-only arguments - Single keyword argument - Multiple keyword arguments - Mixed positional and keyword - Whitespace handling - Complex values - Edge cases - ArgumentConstraint struct usage - Backward compatibility Test Results: - All 10 new tests pass ✓ - 100% coverage on parseKeywordArguments() ✓ - 89.1% overall coverage on dsl package ✓ - No regression in existing tests ✓ - Build successful ✓ This change is backward compatible - existing IR without KeywordArgs continues to work unchanged. Implements: PR #1 from argument-value-checking tech spec Related: Phase 1 - High Priority (200 rules requiring arg checking) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 78.70% 78.73% +0.03%
==========================================
Files 70 70
Lines 6923 6933 +10
==========================================
+ Hits 5449 5459 +10
Misses 1237 1237
Partials 237 237 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shivasurya
added
enhancement
- Add missing period in godot comment - Change JSON tag from keyword_args to keywordArgs (camelCase) Lint now passes: 0 issues
Owner
Author
This was referenced Nov 21, 2025
Owner
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement extends the DSL intermediate representation to support keyword argument constraints in function call matching. The CallMatcherIR structure now includes a KeywordArgs map that allows rules to specify expected values for named parameters. This provides the foundation for more precise security rule definitions that can validate specific argument values rather than just function names.