Skip to content

Conversation

@shivasurya
Copy link
Owner

This extends argument matching to support positional arguments in addition to keyword arguments. Rules can now validate specific argument values by position index, enabling detection of security issues where dangerous values are passed as positional parameters. The implementation includes proper argument extraction from call sites and supports both numeric literal and complex expression values.

@shivasurya shivasurya added enhancement New feature or request go Pull requests that update go code python labels Nov 21, 2025
@shivasurya shivasurya self-assigned this Nov 21, 2025
@safedep
Copy link

safedep bot commented Nov 21, 2025

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.86%. Comparing base (4abbff5) to head (b36aff6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   78.76%   78.86%   +0.09%     
==========================================
  Files          70       70              
  Lines        6990     7011      +21     
==========================================
+ Hits         5506     5529      +23     
+ Misses       1245     1243       -2     
  Partials      239      239              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner Author

shivasurya commented Nov 21, 2025

Merge activity

  • Nov 21, 1:29 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 21, 1:34 AM UTC: Graphite rebased this pull request as part of a merge.
  • Nov 21, 1:35 AM UTC: @shivasurya merged this pull request with Graphite.

@shivasurya shivasurya changed the base branch from shiva/pr-03-python-dsl-api to graphite-base/387 November 21, 2025 01:32
@shivasurya shivasurya changed the base branch from graphite-base/387 to main November 21, 2025 01:33
Extend CallMatcherIR with positional argument constraints to enable precise matching of function calls by argument position and value. This allows security rules to detect dangerous patterns like socket.bind("0.0.0.0") or chmod(file, 0o777).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@shivasurya shivasurya force-pushed the shiva/pr-04-positional-arguments branch from cb10e86 to b36aff6 Compare November 21, 2025 01:34
@shivasurya shivasurya merged commit 4b93037 into main Nov 21, 2025
3 checks passed
@shivasurya shivasurya deleted the shiva/pr-04-positional-arguments branch November 21, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants