Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perlcritic cleanup #2

Merged
merged 17 commits into from Jan 22, 2015
Merged

Perlcritic cleanup #2

merged 17 commits into from Jan 22, 2015

Conversation

@labrown
Copy link

labrown commented Jan 22, 2015

Clean up output of 'perlcritic -1 lib/String/Random.pm'

I created a .perlcriticrc file that ignores the policies you mentioned along with a couple others that don't seem to make the code easier to read. In particular, I ignored the CodeLayout::ProhibitParensWithBuiltins because it seemed to make the code much harder to read.

@shlomif shlomif merged commit c7b87a4 into shlomif:master Jan 22, 2015
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jun 13, 2015
Upstream changes:
0.28    2015-01-22
     - Convert Changes to CPAN::Changes and add t/cpan-changes.t .

0.27    2015-01-22
    - Cache parsed range patterns.
        - Pull Request from Kosuke Asami (co-me). Thanks!
            - shlomif/String-Random#1
    - Clean up the code according to perlcritic.
        - Pull Request from Lance Brown. Thanks!
            - shlomif/String-Random#2
    - Add rand_gen parameter to new to specify a custom random generator.
        - Pull Request from Lance Brown. Thanks!
            - shlomif/String-Random#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.