Perlcritic cleanup #2

merged 17 commits into from Jan 22, 2015


None yet
2 participants

labrown commented Jan 22, 2015

Clean up output of 'perlcritic -1 lib/String/'

I created a .perlcriticrc file that ignores the policies you mentioned along with a couple others that don't seem to make the code easier to read. In particular, I ignored the CodeLayout::ProhibitParensWithBuiltins because it seemed to make the code much harder to read.

@shlomif shlomif merged commit c7b87a4 into shlomif:master Jan 22, 2015

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jun 13, 2015

Update to 0.28
Upstream changes:
0.28    2015-01-22
     - Convert Changes to CPAN::Changes and add t/cpan-changes.t .

0.27    2015-01-22
    - Cache parsed range patterns.
        - Pull Request from Kosuke Asami (co-me). Thanks!
            - shlomif/String-Random#1
    - Clean up the code according to perlcritic.
        - Pull Request from Lance Brown. Thanks!
            - shlomif/String-Random#2
    - Add rand_gen parameter to new to specify a custom random generator.
        - Pull Request from Lance Brown. Thanks!
            - shlomif/String-Random#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment