Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove firstload / reload logic (PRC) #2

merged 1 commit into from Mar 16, 2018


Copy link

@jjatria jjatria commented Mar 15, 2018

As reported in RT #104763, the ReloadConfig method could lead to unexpected behaviour when called on objects that had imported an object that had been created with no file, and had been assigned a filename during their lifetime.

A test file provided in that bug report is included in this patch.

This turned out to be a problem with the firstload / reload logic in ReloadConfig. Its role was apparently to support objects with multiple nested imports while avoiding unnecessary reloads.

However, this appears to have been a feature that was either untested, or not behaving as expected, since removing it entirely still allows the test suite to pass, including the new test.

This closes RT #104763.

This could result in some unexpected behaviour when reloading
a config object that had been created with no file and had
been assigned a filename during its lifetime.

@shlomif shlomif merged commit c6e5a91 into shlomif:master Mar 16, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
continuous-integration/travis-ci/pr The Travis CI build passed
Copy link

@shlomif shlomif commented Mar 16, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.