New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border are allways at 1 pixel offset in containing slot #102

Closed
passenger94 opened this Issue Apr 3, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@passenger94
Contributor

passenger94 commented Apr 3, 2015

Shoes.app width: 100, height: 100 do
    stack width: 80, height: 80, margin: [10,10,0,0] do
        background red
        border blue, strokewidth: 5
    end
end

offsetborder

whatever the border strokewidth and/or stack dimensions

offender : https://github.com/Shoes3/shoes3/blob/master/shoes/ruby.c#L1615

fixed now with

  place.iw -= (int)round(sw);
  place.ih -= (int)round(sw);
  place.ix += (int)round(sw / 2.);
  place.iy += (int)round(sw / 2.);

waiting to submit a pull request with this fix and the fix for slot placement (Nbr100)

@passenger94 passenger94 closed this Apr 4, 2015

@ccoupe ccoupe added this to the 3.2.23 milestone Apr 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment