Radio button issue #274

Closed
dredknight opened this Issue Oct 8, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@dredknight
Contributor

dredknight commented Oct 8, 2016

Hello everyone!

Its very simple this time... I broke Shoes. Here is a simple code that will show the issue.
When you click on the button and the flow gets refreshed Shoes crashes.
If you comment the "Radio" thing it works fine. Whats going on?

Shoes.app do
    @a=flow do
        background green
        radio;
    end
    button "refresh" do 
        @a.clear do
            background green
            radio; ### try to comment this one
        end
    end
end
@passenger94

This comment has been minimized.

Show comment
Hide comment
@passenger94

passenger94 Oct 8, 2016

Contributor

Yes, a bug ! Thanks !
Gtk-CRITICAL **: gtk_radio_button_get_group: assertion 'GTK_IS_RADIO_BUTTON (radio_button)' failed
works fine with a check button, so something must be wrong in C/Gtk radio code probably ...

Contributor

passenger94 commented Oct 8, 2016

Yes, a bug ! Thanks !
Gtk-CRITICAL **: gtk_radio_button_get_group: assertion 'GTK_IS_RADIO_BUTTON (radio_button)' failed
works fine with a check button, so something must be wrong in C/Gtk radio code probably ...

@passenger94

This comment has been minimized.

Show comment
Hide comment
@passenger94

passenger94 Oct 8, 2016

Contributor

Got it !
https://github.com/Shoes3/shoes3/blob/master/shoes/canvas.c#L1568
someone forgot an exclamation point ! ;-)
Should be if (!NIL_P(shoes_hash_get(canvas->app->groups, group)))
exclamation mark before NIL_P is missing.

Contributor

passenger94 commented Oct 8, 2016

Got it !
https://github.com/Shoes3/shoes3/blob/master/shoes/canvas.c#L1568
someone forgot an exclamation point ! ;-)
Should be if (!NIL_P(shoes_hash_get(canvas->app->groups, group)))
exclamation mark before NIL_P is missing.

@ccoupe

This comment has been minimized.

Show comment
Hide comment
@ccoupe

ccoupe Oct 9, 2016

Contributor

Thanks. I've made the change to master.

Contributor

ccoupe commented Oct 9, 2016

Thanks. I've made the change to master.

ccoupe added a commit that referenced this issue Oct 9, 2016

@ccoupe ccoupe added the High label Oct 9, 2016

@ccoupe ccoupe added this to the 3.3.2 milestone Oct 9, 2016

@dredknight

This comment has been minimized.

Show comment
Hide comment
Contributor

dredknight commented Oct 9, 2016

@ccoupe

This comment has been minimized.

Show comment
Hide comment
@ccoupe

ccoupe Jan 21, 2017

Contributor

Closed in Shoes 3.3.2

Contributor

ccoupe commented Jan 21, 2017

Closed in Shoes 3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment