Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button issue #274

Closed
dredknight opened this issue Oct 8, 2016 · 5 comments
Closed

Radio button issue #274

dredknight opened this issue Oct 8, 2016 · 5 comments
Labels
Milestone

Comments

@dredknight
Copy link
Contributor

@dredknight dredknight commented Oct 8, 2016

Hello everyone!

Its very simple this time... I broke Shoes. Here is a simple code that will show the issue.
When you click on the button and the flow gets refreshed Shoes crashes.
If you comment the "Radio" thing it works fine. Whats going on?

Shoes.app do
    @a=flow do
        background green
        radio;
    end
    button "refresh" do 
        @a.clear do
            background green
            radio; ### try to comment this one
        end
    end
end
@passenger94
Copy link
Contributor

@passenger94 passenger94 commented Oct 8, 2016

Yes, a bug ! Thanks !
Gtk-CRITICAL **: gtk_radio_button_get_group: assertion 'GTK_IS_RADIO_BUTTON (radio_button)' failed
works fine with a check button, so something must be wrong in C/Gtk radio code probably ...

@passenger94
Copy link
Contributor

@passenger94 passenger94 commented Oct 8, 2016

Got it !
https://github.com/Shoes3/shoes3/blob/master/shoes/canvas.c#L1568
someone forgot an exclamation point ! ;-)
Should be if (!NIL_P(shoes_hash_get(canvas->app->groups, group)))
exclamation mark before NIL_P is missing.

@ccoupe
Copy link
Contributor

@ccoupe ccoupe commented Oct 9, 2016

Thanks. I've made the change to master.

ccoupe added a commit that referenced this issue Oct 9, 2016
@ccoupe ccoupe added the High label Oct 9, 2016
@ccoupe ccoupe added this to the 3.3.2 milestone Oct 9, 2016
@dredknight
Copy link
Contributor Author

@dredknight dredknight commented Oct 9, 2016

@ccoupe
Copy link
Contributor

@ccoupe ccoupe commented Jan 21, 2017

Closed in Shoes 3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants