New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click event not working when a scroll bar is scrolled down #35

Closed
BackOrder opened this Issue Jan 20, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@BackOrder
Collaborator

BackOrder commented Jan 20, 2015

The click event is not working when there is a vertical scroll bar scrolled down (slightly or entirely).

_TEST SCENARIOS_
TEST (1)

  • Run the script below
  • Open Shoes console (alt-/)
  • Click anywhere in the window
  • Check Shoes console

EXPECTED RESULT the button number and coordinates displayed in Shoes console.

TEST (2)

  • Scroll down
  • Click anywhere in the window
  • Check Shoes console

EXPECTED RESULT the button number and coordinates displayed in Shoes console.

CURRENT RESULT nothing is displayed. ❗️

TEST (3)

  • Scroll all way up
  • Click anywhere in the window
  • Check Shoes console

EXPECTED RESULT the button number and coordinates displayed in Shoes console.

Shoes.app {
   click { |n, l, t| info "#{n}, (#{l}, #{t})" }
   (0..100).map { [*('A'..'Z')].sample(rand(25) + 1) }.each { |n|
      para n
   }
}

@BackOrder BackOrder added the Windows label Jan 20, 2015

@ccoupe ccoupe added Linux OSX labels Jan 20, 2015

@BackOrder

This comment has been minimized.

Show comment
Hide comment
@BackOrder

BackOrder Jan 20, 2015

Collaborator

The following code snippet demonstrates that keypress is not affected by this issue.

Shoes.app {
   keypress { |n| info "keypressed: #{n}" }
   (0..100).map { [*('A'..'Z')].sample(rand(25) + 1) }.each { |n|
      para n
   }
}
Collaborator

BackOrder commented Jan 20, 2015

The following code snippet demonstrates that keypress is not affected by this issue.

Shoes.app {
   keypress { |n| info "keypressed: #{n}" }
   (0..100).map { [*('A'..'Z')].sample(rand(25) + 1) }.each { |n|
      para n
   }
}
@BackOrder

This comment has been minimized.

Show comment
Hide comment
@BackOrder

BackOrder Jan 23, 2015

Collaborator

The problem may be related to #2 and shoes#42 considering that the clickable region seems to be limited to the window size. The text in bold shows the inner limit, anything clicked beyond that will not be caught by the click event.

Shoes.app {
   click { |n, l, t| info "#{n}, (#{l}, #{t})" }
   (0..100).map { [*('A'..'Z')].sample(80) }.each_with_index { |n, i|
      para (i == 28 or i == 29) ? strong(n) : n
   }
}
Collaborator

BackOrder commented Jan 23, 2015

The problem may be related to #2 and shoes#42 considering that the clickable region seems to be limited to the window size. The text in bold shows the inner limit, anything clicked beyond that will not be caught by the click event.

Shoes.app {
   click { |n, l, t| info "#{n}, (#{l}, #{t})" }
   (0..100).map { [*('A'..'Z')].sample(80) }.each_with_index { |n, i|
      para (i == 28 or i == 29) ? strong(n) : n
   }
}
@passenger94

This comment has been minimized.

Show comment
Hide comment
@passenger94

passenger94 Apr 17, 2015

Contributor

i think i have it
needs testing ...

Edit : mmm not perfect, on good tracks though !

Contributor

passenger94 commented Apr 17, 2015

i think i have it
needs testing ...

Edit : mmm not perfect, on good tracks though !

passenger94 added a commit to passenger94/shoes3 that referenced this issue Apr 17, 2015

@passenger94

This comment has been minimized.

Show comment
Hide comment
@passenger94

passenger94 Apr 17, 2015

Contributor

should be good now but lots of tests won't hurt, please

Contributor

passenger94 commented Apr 17, 2015

should be good now but lots of tests won't hurt, please

@ccoupe ccoupe added this to the 3.2.23 milestone Apr 21, 2015

@ccoupe

This comment has been minimized.

Show comment
Hide comment
@ccoupe

ccoupe Apr 21, 2015

Contributor

Thanks. OSX behaves properly (enough - who really counts pixels ;^)

Contributor

ccoupe commented Apr 21, 2015

Thanks. OSX behaves properly (enough - who really counts pixels ;^)

passenger94 added a commit to passenger94/shoes3 that referenced this issue Apr 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment