Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoes Windows could have themes #354

Closed
ccoupe opened this issue May 16, 2017 · 7 comments
Closed

Shoes Windows could have themes #354

ccoupe opened this issue May 16, 2017 · 7 comments

Comments

@ccoupe
Copy link
Contributor

@ccoupe ccoupe commented May 16, 2017

Continued from #345

One problem with having the user download and switch themes is that Windows wants Admin rights to wrire into Common Files (x86). Fortunately, Gtk has some not well known/documented ways to find settings.ini

If you create %USER%%APPDATA%\Local\gtk-3\settings.ini that it will override any previous setting found during gtk initialization. I tried it. It works. Now, we need a place to store the user supplied/downloaded themes so GTK can find them and of course GTK has many options for doing that., also not well documented for Windows.I just need to find one that is user writeable.

@ccoupe
Copy link
Contributor Author

@ccoupe ccoupe commented May 16, 2017

Many Gtk themes will work so-so with Shoes and some not at all. From the shoes perspective, they are bloated with lots of things Shoes/Windows doesn't need and can't use so it is problematic to make it Shoes easy.

@ccoupe
Copy link
Contributor Author

@ccoupe ccoupe commented May 16, 2017

see wiki

@dredknight
Copy link
Contributor

@dredknight dredknight commented May 23, 2017

Splendid!

@ccoupe ccoupe mentioned this issue Feb 27, 2018
Closed
@ccoupe
Copy link
Contributor Author

@ccoupe ccoupe commented May 6, 2018

This will be fun for the curious. It's only working on Linux (so far). The first image is my default theme. The second image is from a Gtk3 Theme named XP
theme-default-combo
theme-xp-combo

You need a Gtk3 theme without ties to different theme engines. For example, the FlatStudio theme is tied to the unico theme engire and doesn't work with Shoes (on my Linux system)

@ccoupe ccoupe added this to the 3.3.7 milestone May 6, 2018
@ccoupe
Copy link
Contributor Author

@ccoupe ccoupe commented May 6, 2018

Switching theme is pretty simple.
theme-switch
The real problem is that most of the Gtk3 themes I've tried have failed to parse. Since I have no css skills that's going to slow progress.

ccoupe added a commit that referenced this issue May 6, 2018
* kind of works if the theme is really really clean
@ccoupe ccoupe added the Linux label May 7, 2018
@ccoupe ccoupe self-assigned this May 7, 2018
@ccoupe
Copy link
Contributor Author

@ccoupe ccoupe commented May 7, 2018

I've got 3.3.7 betas for Windows, Linux X86 and freebsd that will load a theme from ~/.shoes/themes Appdata/Local/Shoes/themes for Windows. Note: That's a user writable space. You'll want a theme that works like XP Untar it , create the above directory and move the XP directory to it. Cobbler->Theme->Switch should finds it. Save. Restart Shoes. If you launch from the terminal you'll get a message that it load the theme.Or if you add a poor theme to the directory, you'll get screen or two of parsing errors to fix.

That about the end of what I can do. Somebody else can deal with bad css.

@ccoupe
Copy link
Contributor Author

@ccoupe ccoupe commented Jan 16, 2019

Closing 3.3.7 issues.

@ccoupe ccoupe closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants