New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit_line does not align #7

Closed
ccoupe opened this Issue Dec 23, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@ccoupe
Contributor

ccoupe commented Dec 23, 2014

@ccoupe ccoupe added the OSX label Dec 24, 2014

@ccoupe

This comment has been minimized.

Show comment
Hide comment
@ccoupe

ccoupe Mar 15, 2015

Contributor

This is a weird bug. For shoes_native_edit_line the incoming place->iy arg is +4 and it sticks for all widgets that follow. Additional edit_lines in a flow will increase iy by another 4. Also place->iw is 104 instead of 100. Why or how would flow layout do that?

Shoes.app :width => 800 do
    para "First"
    list_box :width => 100
    @e1 = edit_line :width => 100, :state => "disabled"
    para "Two"
    list_box :width => 100
    @e2 =edit_line :width => 100, :state => "disabled"
    para "Three"
    @e3 = edit_box :width => 100, :state => "disabled"
    para "Four"
    @e4 = edit_line width: 100, :state => "disabled"
    para "Five"
end
Contributor

ccoupe commented Mar 15, 2015

This is a weird bug. For shoes_native_edit_line the incoming place->iy arg is +4 and it sticks for all widgets that follow. Additional edit_lines in a flow will increase iy by another 4. Also place->iw is 104 instead of 100. Why or how would flow layout do that?

Shoes.app :width => 800 do
    para "First"
    list_box :width => 100
    @e1 = edit_line :width => 100, :state => "disabled"
    para "Two"
    list_box :width => 100
    @e2 =edit_line :width => 100, :state => "disabled"
    para "Three"
    @e3 = edit_box :width => 100, :state => "disabled"
    para "Four"
    @e4 = edit_line width: 100, :state => "disabled"
    para "Five"
end
@BackOrder

This comment has been minimized.

Show comment
Hide comment
@BackOrder

BackOrder Mar 15, 2015

Collaborator

There are hardcoded default styles in Shoes code that may indirectly affect edit_line.

Collaborator

BackOrder commented Mar 15, 2015

There are hardcoded default styles in Shoes code that may indirectly affect edit_line.

@ccoupe

This comment has been minimized.

Show comment
Hide comment
@ccoupe

ccoupe Mar 15, 2015

Contributor

I suspect the answer is at ruby.c:3172

Contributor

ccoupe commented Mar 15, 2015

I suspect the answer is at ruby.c:3172

@BackOrder

This comment has been minimized.

Show comment
Hide comment
@BackOrder

BackOrder Mar 15, 2015

Collaborator

You are right. It makes sense.

Collaborator

BackOrder commented Mar 15, 2015

You are right. It makes sense.

@ccoupe

This comment has been minimized.

Show comment
Hide comment
@ccoupe

ccoupe Mar 15, 2015

Contributor

There are other places in ruby.c where #SHOES_QUARTZ is used to adjust place.h and place.ih.
Commenting out the other adjustments near line 3172 and leaving place.h and place.ih appears to work.

Contributor

ccoupe commented Mar 15, 2015

There are other places in ruby.c where #SHOES_QUARTZ is used to adjust place.h and place.ih.
Commenting out the other adjustments near line 3172 and leaving place.h and place.ih appears to work.

@ccoupe ccoupe closed this in 2786a66 Mar 15, 2015

@ccoupe ccoupe self-assigned this Mar 15, 2015

@ccoupe ccoupe added this to the 3.2.22 milestone Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment