Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help improving shoesrb website design #5

Merged
merged 3 commits into from Jan 29, 2013
Merged

Conversation

wpp
Copy link
Contributor

@wpp wpp commented Jan 17, 2013

The homepage now contains 4 major pages:

  • The landing/home page.
  • Contributers page for people interested in contributing.
  • Tutorials page for people interested in learning Shoes.
  • Blog

contribute
tutorials
blog

The About page is empty for now but would be great to have some information
about Shoes here.

Additional Note: The texts for the page are not that great. Partly because
I had English as a second language in school :) So improvements are welcome.
Also: The background images (and header of tutorials page) are taken from
Nobody Knows Shoes, I thought it would be nice to have a bit of _why on the
site. ❤️

The homepage now contains 4 major pages:

* The landing/home page.
* Contributers page for people interested in contributing.
* Tutorials page for people interested in learning Shoes.
* Blog

The About page is empty for now but would be great to have some information
about Shoes here.

Additional Note: The texts for the page are not that great. Partly because
I had English as a second language in school :) So improvements are welcome.
@jrgifford
Copy link
Member

The only problem (and I mean the only problem) I have with this is that it's very image-heavy, and that the images are high-quality.

Other than that, great job! Does anyone know how we could shrink these images down to something so it won't take forever to load on a 1MBsDown/512KBsUp connection? I've never done anything like it before...

@wpp
Copy link
Contributor Author

wpp commented Jan 18, 2013

Good point. Totally forgot about that. I'll try making these images smaller give you some numbers then.

@PragTob
Copy link
Member

PragTob commented Jan 18, 2013

Looks awesome thanks!

@davorb
Copy link
Member

davorb commented Jan 18, 2013

I like what you've done with the site, but here are a few things that we might want to look into.

  1. We need to change the colour scheme.
  2. The contribute page is an awesome idea, but i'm kind of annoyed that the box with users doesn't have the same margin-right as margin-left. It looks a bit weird.
  3. We should use CDNs to speed things up. Perhaps put the entire site on Amazon S3 and make use of CloudFront?
  4. What does the first page look like? What we want is something with a big "Get Shoes4"-button and then below that perhaps something that shows why Shoes is so great. Sort of like the JRuby, Ruboto or Rubinius sites.

@davorb davorb mentioned this pull request Jan 18, 2013
@steveklabnik
Copy link
Member

With the number of requests that we get, CDNs/CloudFront is simply not necessary.

@steveklabnik
Copy link
Member

Why do we need to change the color scheme?

@wpp
Copy link
Contributor Author

wpp commented Jan 18, 2013

  • @davorb I especially agree with Point 4. The home page should have a download button/link. And I really like rubnius' little snippets on how to get started. When you say "why shoes is great" do you mean text?
  • I feel like "color scheme" is a pretty hard problem (in general) and I'm not a designer.
  • Point 2: Ha, now that you mentioned it, I cannot unsee and it shall be fixed 🙏

@davorb
Copy link
Member

davorb commented Jan 18, 2013

Yes, you're right about the CDN.

But not even changing the twitter bootstrap-black bar at the top just

feels lazy. So I think that we should at least change that.

Davor Babic
davor@davor.se

Steve Klabnik wrote:

Why do we need to change the color scheme?


Reply to this email directly or view it on GitHub
#5 (comment).

@steveklabnik
Copy link
Member

Absolutely nobody except the most hardcore of nerds knows anything about Bootstrap. I show people the default black bar all the time, and they think it's gorgeous.

That said, I'm also partial to black. ;)

@jrgifford
Copy link
Member

plus, we can get shoes featured on http://builtwithbootstrap.com/ !! 🤘

James Gifford
cell: 2162238574

On Fri, Jan 18, 2013 at 11:21 AM, Steve Klabnik notifications@github.comwrote:

Absolutely nobody except the most hardcore of nerds knows anything about
Bootstrap. I show people the default black bar all the time, and they think
it's gorgeous.

That said, I'm also partial to black. ;)


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-12429218.

@wpp
Copy link
Contributor Author

wpp commented Jan 22, 2013

Hey guys! Sry but I've been busy, however shoesrb.com shall not be forgotten!

To reduce the image size I converted the biggest images to jpg and lowered the quality. I also combined some of them into things called "sprites" :)

Before:

zsh-1

Now:

zsh 2

Contributors are centered now :)

Screen Shot 2013-01-22 at 10 18 17 PM

Lemme know what ya'll thinkin 🍔

@davorb
Copy link
Member

davorb commented Jan 22, 2013

Nice! :-)

If you look at the white box that the red shoes logo is floating in, you will notice that it sticks out more to the left than the gray box does. You might want to fix that.

@wpp
Copy link
Contributor Author

wpp commented Jan 29, 2013

@davorb you sir got some eagle eye vision going on 👍 fixed it.

steveklabnik added a commit that referenced this pull request Jan 29, 2013
Help improving shoesrb website design
@steveklabnik steveklabnik merged commit 8b2462f into shoes:master Jan 29, 2013
@steveklabnik
Copy link
Member

Merging! I like what's here so far.

I would like to update the site ASAP, as the old shoes-web is running 2.3.5, which has some security holes. This one should not. :)

@steveklabnik
Copy link
Member

... so I guess what I'm saying is that I might push this up, because it's Good Enough, and if we find another few small things we can keep tweaking them. :)

@steveklabnik
Copy link
Member

Yep! I'm deploying this now, looks great so far :D

@steveklabnik
Copy link
Member

It's live: http://shoesrb.com

@jrgifford
Copy link
Member

👍 looks good!

@wpp
Copy link
Contributor Author

wpp commented Jan 29, 2013

Awesome 👍

@wpp
Copy link
Contributor Author

wpp commented Jan 29, 2013

Totally forgot: https://www.youtube.com/watch?v=hmbUNF1Q4R8

@nbouhid
Copy link

nbouhid commented Jan 29, 2013

Sorry to interrupt guys, but I have to ask you something. Why did you delete the downloads section??

@steveklabnik
Copy link
Member

One issue with downloads is that GitHub is not hosting binary stuff any more, so I have to move them to my s3 bucket and create a redirect on the site. @nbouhid this is a bug, mind opening another ticket, since you discovered it?!

@wasnotrice
Copy link
Member

@steveklabnik I'm going to be putting up some packaging files on S3 too. Is there any reason not to use our personal buckets?

@wasnotrice
Copy link
Member

Plus, new design: 🤘

@steveklabnik
Copy link
Member

I don't think so, other than committing to keeping them up.

@davorb
Copy link
Member

davorb commented Jan 30, 2013

First of all, the site looks great! greeeaat

Here's a couple of more thoughts.
https://www.dropbox.com/s/jro5ifzsihvgdz0/Screen%20Shot%202013-01-30%20at%208.13.20%20AM.png

https://www.dropbox.com/s/27wawpzwu9kwq00/Screen%20Shot%202013-01-30%20at%208.19.15%20AM.png

I'm not sure what the icons would look like if we made them stick "up" instead of "down" (or if it would even be an improvement). But you might want to try it out and see what it looks like.

In any case. The site looks great and I'm just nitpicking.

@ashbb
Copy link
Member

ashbb commented Jan 30, 2013

@wpp @steveklabnik and folks Awesome!! I LOVE new Shoes site. Great work, thanks!

The following is my two cents. ;-)

  • There is a button named "Read the blog >>" on top page. But it links to the contribute page. Is this right?
  • The Manual link on Tutorials page is broken.
  • About the Shoes Blog page. Who can post?
  • About Contribute page. We merged Brown Shoes and Purple Shoes into Shoes 4. So, IMHO, the Brown Shoes link may not be necessary any more.
  • About the Shoes Team. There are only 10 members on Contribute page. But I think there are more people contributed to Shoes. Oh, @wpp is not listed!
  • How about adding a link to Shoes ML on "About" page?

@steveklabnik
Copy link
Member

  1. I will fix that now.
  2. I just fixed it
  3. Anyone who submits one! There is a rake task which makes a new post, you write it in markdown, commit, and send a PR. 😄
  4. Good idea.
  5. Yep! this should get improved
  6. Sounds good, I will do that now too.

If anyone wants to tackle 4 or 5, feel free!

@steveklabnik
Copy link
Member

Actually, I'll remove the brown shoes link too.

I'm going to add the ML on the 'contribute' page too.

Also, the about page could use some improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants