Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement NamedValueChecker #42

Merged
merged 4 commits into from Jan 15, 2020
Merged

Conversation

@Songmu
Copy link
Contributor

Songmu commented Jan 15, 2020

Upgrading the version of the mysql driver to 1.5.0 in our code resulted in an error. This was due to the fact that the mysql driver can now handle uint64 natively and that go-sql-proxy does not support NamedValueChecker.

Added support for NamedValueChecker in this pull request.

ref. https://golang.org/pkg/database/sql/driver/#NamedValueChecker

@Songmu

This comment has been minimized.

Copy link
Contributor Author

Songmu commented Jan 15, 2020

Is Go1.8 support required? I'll make corrections if necessary. @shogo82148

@Songmu Songmu force-pushed the Songmu:NamedValueChecker branch from af22362 to 236616c Jan 15, 2020
@shogo82148

This comment has been minimized.

Copy link
Owner

shogo82148 commented Jan 15, 2020

Thanks!
Go1.8 support is not required, it's just for fun :)

@shogo82148 shogo82148 merged commit d681b4a into shogo82148:master Jan 15, 2020
19 checks passed
19 checks passed
Test (ubuntu-latest, 1.8)
Details
Test (ubuntu-latest, 1.9)
Details
Test (ubuntu-latest, 1.10) Test (ubuntu-latest, 1.10)
Details
Test (ubuntu-latest, 1.11) Test (ubuntu-latest, 1.11)
Details
Test (ubuntu-latest, 1.12) Test (ubuntu-latest, 1.12)
Details
Test (ubuntu-latest, 1.13) Test (ubuntu-latest, 1.13)
Details
Test (windows-latest, 1.8)
Details
Test (windows-latest, 1.9)
Details
Test (windows-latest, 1.10) Test (windows-latest, 1.10)
Details
Test (windows-latest, 1.11) Test (windows-latest, 1.11)
Details
Test (windows-latest, 1.12) Test (windows-latest, 1.12)
Details
Test (windows-latest, 1.13) Test (windows-latest, 1.13)
Details
Test (macos-latest, 1.8)
Details
Test (macos-latest, 1.9)
Details
Test (macos-latest, 1.10) Test (macos-latest, 1.10)
Details
Test (macos-latest, 1.11) Test (macos-latest, 1.11)
Details
Test (macos-latest, 1.12) Test (macos-latest, 1.12)
Details
Test (macos-latest, 1.13) Test (macos-latest, 1.13)
Details
finish
Details
@Songmu Songmu deleted the Songmu:NamedValueChecker branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.