Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register parameters of SVM #7

Merged
merged 1 commit into from Jul 7, 2018
Merged

Register parameters of SVM #7

merged 1 commit into from Jul 7, 2018

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Jul 7, 2018

No description provided.

void CSVMLin::init()
{
SG_ADD(
&use_bias, "use_bias", "Indicates if bias is used.", MS_NOT_AVAILABLE);

This comment has been minimized.

@karlnapf

karlnapf Jul 7, 2018
Member

I wonder: are those things not registered in the base class?
If not why not?

m_parameters->add(&count, "count", "count");
m_parameters->add(&use_bias, "use_bias", "Indicates if bias is used.");
m_parameters->add(&use_regularized_bias, "use_regularized_bias", "Indicates if bias is regularized.");
SG_ADD(&C1, "C1", "Cost constant 1.", MS_AVAILABLE);

This comment has been minimized.

@karlnapf

karlnapf Jul 7, 2018
Member

because then we need to register them everytime ...

This comment has been minimized.

@vinx13

vinx13 Jul 7, 2018
Author Member

actually they don't inherit from SVM base class

This comment has been minimized.

@karlnapf

karlnapf Jul 7, 2018
Member

seems quite mad....
can you see any idea why that is?
On the other hand, you are just porting examples, so no need to refactor things ....

m_parameters->add(&use_regularized_bias, "use_regularized_bias", "Indicates if bias is regularized.");
SG_ADD(&C1, "C1", "Cost constant 1.", MS_AVAILABLE);
SG_ADD(&C2, "C2", "Cost constant 2.", MS_AVAILABLE);
SG_ADD(&wscale, "wscale", "W scale", MS_NOT_AVAILABLE);

This comment has been minimized.

@karlnapf

karlnapf Jul 7, 2018
Member

are these parameters necessary to be accessible from the outside/equals/serilazation, or are they only to store the intermediate state of training?

@karlnapf karlnapf merged commit 79d42cb into shogun-toolbox:master Jul 7, 2018
@karlnapf
Copy link
Member

@karlnapf karlnapf commented Jul 7, 2018

anyways, will merge for now and we can come back to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants