Register parameters of SVM #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Jul 7, 2018
| void CSVMLin::init() | ||
| { | ||
| SG_ADD( | ||
| &use_bias, "use_bias", "Indicates if bias is used.", MS_NOT_AVAILABLE); |
There was a problem hiding this comment.
I wonder: are those things not registered in the base class?
If not why not?
karlnapf
reviewed
Jul 7, 2018
| m_parameters->add(&count, "count", "count"); | ||
| m_parameters->add(&use_bias, "use_bias", "Indicates if bias is used."); | ||
| m_parameters->add(&use_regularized_bias, "use_regularized_bias", "Indicates if bias is regularized."); | ||
| SG_ADD(&C1, "C1", "Cost constant 1.", MS_AVAILABLE); |
There was a problem hiding this comment.
because then we need to register them everytime ...
There was a problem hiding this comment.
actually they don't inherit from SVM base class
There was a problem hiding this comment.
seems quite mad....
can you see any idea why that is?
On the other hand, you are just porting examples, so no need to refactor things ....
karlnapf
reviewed
Jul 7, 2018
| m_parameters->add(&use_regularized_bias, "use_regularized_bias", "Indicates if bias is regularized."); | ||
| SG_ADD(&C1, "C1", "Cost constant 1.", MS_AVAILABLE); | ||
| SG_ADD(&C2, "C2", "Cost constant 2.", MS_AVAILABLE); | ||
| SG_ADD(&wscale, "wscale", "W scale", MS_NOT_AVAILABLE); |
There was a problem hiding this comment.
are these parameters necessary to be accessible from the outside/equals/serilazation, or are they only to store the intermediate state of training?
|
anyways, will merge for now and we can come back to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.